incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Animesh Chaturvedi <animesh.chaturv...@citrix.com>
Subject RE: Review Request: (CLOUDSTACK-1475) update keystore in SSVM and change download iso/template url after Update SSL Certificate
Date Thu, 14 Mar 2013 19:11:26 GMT
Nitin, Jayaal

Please review and apply the patch if satisfied

Animesh

> -----Original Message-----
> From: Prasanna Santhanam [mailto:noreply@reviews.apache.org] On Behalf
> Of Prasanna Santhanam
> Sent: Wednesday, March 06, 2013 2:06 AM
> To: Jayapal Reddy Uradi; Nitin Mehta
> Cc: cloudstack; Prasanna Santhanam; Wei Zhou
> Subject: Re: Review Request: (CLOUDSTACK-1475) update keystore in SSVM
> and change download iso/template url after Update SSL Certificate
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9696/
> -----------------------------------------------------------
> 
> (Updated March 6, 2013, 10:06 a.m.)
> 
> 
> Review request for cloudstack, Nitin Mehta and Jayapal Reddy.
> 
> 
> Changes
> -------
> 
> Can you guys help review this? The patch is for 4.0.1 but should be applicable
> for master too
> 
> 
> Description
> -------
> 
> This patch is for issue CLOUD-1475 (RegisterISO error after Update SSL
> Certificate) on CloudStack 4.0.1.
> 
> 
> Changes include:
> (1) update realhostip.keystore in SSVM (see the change in config_ssl.sh)
> (2) change suffix of download iso/template url rom realhostip.com to
> domain_suffix in SSL Certificate.
> (3) validate download URL because ssvm publicip or domain suffix may
> change.
> 
> 
> This addresses bug CLOUD-1475.
> 
> 
> Diffs
> -----
> 
> 
> agent/src/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.
> java 48f5079
>   console-proxy/scripts/config_ssl.sh 8d80c47
>   core/src/com/cloud/storage/resource/CifsSecondaryStorageResource.java
> c606fca
>   core/src/com/cloud/storage/resource/NfsSecondaryStorageResource.java
> 155210d
>   server/src/com/cloud/configuration/Config.java dbcc97a
> 
> server/src/com/cloud/consoleproxy/AgentBasedConsoleProxyManager.java
> 01b4720
> 
> server/src/com/cloud/consoleproxy/AgentBasedStandaloneConsoleProxyM
> anager.java 6172780
>   server/src/com/cloud/consoleproxy/StaticConsoleProxyManager.java
> d2df83c
>   server/src/com/cloud/server/ConfigurationServerImpl.java 3368c9b
>   server/src/com/cloud/storage/download/DownloadMonitorImpl.java
> 2736777
>   server/src/com/cloud/storage/upload/UploadMonitorImpl.java 4231be8
> 
> Diff: https://reviews.apache.org/r/9696/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> 
> We need to restart management-server after Update SSL Certificate
> 
> 
> Thanks,
> 
> Wei Zhou

Mime
View raw message