incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sanjeev Neelarapu <sanjeev.neelar...@citrix.com>
Subject RE: Review Request: Two test cases from snapshots imporevement feature
Date Wed, 06 Mar 2013 08:48:38 GMT
Thanks for the comments David.
I will add the ASF license header and test_concurrent_snapshot.py is not the intended one.
I will remove it.

Thanks,
Sanjeev

From: David Nalley [mailto:noreply@reviews.apache.org] On Behalf Of David Nalley
Sent: Tuesday, March 05, 2013 10:49 PM
To: Prasanna Santhanam
Cc: cloudstack; Sanjeev Neelarapu; David Nalley
Subject: Re: Review Request: Two test cases from snapshots imporevement feature

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9752/




First - thanks for working on tests!! It's something we need lots of.

Both of these files are missing the ASF license header, please add that in.

test/integration/component/test_concurrent_snapshot.py<https://reviews.apache.org/r/9752/diff/1/?file=266195#file266195line1>
(Diff revision 1)


None


1


test


This doesn't look like valid python to me. Are you sure this is the intended content?


- David


On March 5th, 2013, 5:15 p.m., sanjeev n wrote:
Review request for cloudstack and Prasanna Santhanam.
By sanjeev n.

Updated March 5, 2013, 5:15 p.m.

Description

Added two test cases for snapshots improvement feature.


Testing

Executed the tests in advanced zone setup.


Diffs

 *   test/integration/component/test_concurrent_snapshot.py (PRE-CREATION)
 *   test/integration/component/test_snapshots_improvements.py (PRE-CREATION)

View Diff<https://reviews.apache.org/r/9752/diff/>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message