incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chip Childers" <chip.child...@sungard.com>
Subject Re: Review Request: fix /etc/hosts error in virtual router
Date Tue, 12 Mar 2013 20:39:33 GMT


> On March 12, 2013, 8:25 p.m., Chip Childers wrote:
> > patches/systemvm/debian/config/root/edithosts.sh, line 92
> > <https://reviews.apache.org/r/9882/diff/1/?file=269608#file269608line92>
> >
> >     I'm not familiar enough with the script to know why this fixes the issue.  Can
you explain the fix please?
> 
> Wei Zhou wrote:
>     Chip, 
>     I add a space after $host, so that the last sentence  (sed -i  /"$host "/d $HOSTS)
 will remove the line which includes "$host " (please notice there is a space after $host).
>     Currently it can not remove it because no space after $host and no lines will match
"$host ".

Ah!  Brittle scripts are fun.  Thanks for explaining the fix.


- Chip


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9882/#review17749
-----------------------------------------------------------


On March 12, 2013, 7:33 p.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9882/
> -----------------------------------------------------------
> 
> (Updated March 12, 2013, 7:33 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> When create the instance with the name same to previous instances, the /etc/hosts in
virtual router has an error. 
> 
> For example:
> 192.168.0.1 r-148-VM
> 192.168.0.1 r-148-VM
> 192.168.0.99 test-w006-001
> 192.168.0.138 test-w006-002
> 192.168.0.37 test-w006-003
> 192.168.0.33 test-w006-004
> 192.168.0.1 r-148-VM
> 192.168.0.235 test-w006-001
> 192.168.0.17 test-w006-002
> 
> It should be:
> 192.168.0.37 test-w006-003 
> 192.168.0.33 test-w006-004 
> 192.168.0.1 r-148-VM 
> 192.168.0.235 test-w006-001 
> 192.168.0.17 test-w006-002 
> 
> 
> This addresses bug CLOUDSTACK-1652.
> 
> 
> Diffs
> -----
> 
>   patches/systemvm/debian/config/root/edithosts.sh 3c6102d 
> 
> Diff: https://reviews.apache.org/r/9882/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message