incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chip Childers" <chip.child...@sungard.com>
Subject Re: Review Request: Spring fails to self inject the ApiDiscoveryServiceImpl pluggable service, add manually to service impl
Date Tue, 12 Mar 2013 13:14:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9872/#review17733
-----------------------------------------------------------


This patch does not apply within 4.1:

git am ~/Downloads/0001-plugins-Add-it-s-to-cmdClass-in-ApiDiscovery-spring-.patch
Applying: plugins: Add it's to cmdClass in ApiDiscovery, spring fails to self inject
error: patch failed: plugins/api/discovery/src/org/apache/cloudstack/discovery/ApiDiscoveryServiceImpl.java:73
error: plugins/api/discovery/src/org/apache/cloudstack/discovery/ApiDiscoveryServiceImpl.java:
patch does not apply
Patch failed at 0001 plugins: Add it's to cmdClass in ApiDiscovery, spring fails to self inject



- Chip Childers


On March 12, 2013, 9:18 a.m., Rohit Yadav wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9872/
> -----------------------------------------------------------
> 
> (Updated March 12, 2013, 9:18 a.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> -------
> 
> Spring fails to inject the class itself which is a pluggable service. A minor issue,
but the listApis won't list the "listApis" API itself.
> So, we manually addAll getCommands() from the class to the cmdClass (the list of cmd
classes)
> 
> 
> Diffs
> -----
> 
>   plugins/api/discovery/src/org/apache/cloudstack/discovery/ApiDiscoveryServiceImpl.java
293a1a4 
> 
> Diff: https://reviews.apache.org/r/9872/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rohit Yadav
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message