incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chip Childers" <chip.child...@sungard.com>
Subject Re: Review Request: Fix XS 6.1 Guest OS support
Date Mon, 11 Mar 2013 02:07:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9839/#review17668
-----------------------------------------------------------


There are a couple of minor questions I have (see line specific comments).  Can you please
correct or answer, and then submit a new patch?


plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java
<https://reviews.apache.org/r/9839/#comment37541>

    Why are you removing Debian Lenny here?



plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java
<https://reviews.apache.org/r/9839/#comment37542>

    Minor nit, but these should probably be ordered after Ubuntu 10.10.



plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer610Resource.java
<https://reviews.apache.org/r/9839/#comment37543>

    I think this is the core of of what you meant to change, and it looks right to me.


- Chip Childers


On March 10, 2013, 7:39 p.m., Dennis Lawler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9839/
> -----------------------------------------------------------
> 
> (Updated March 10, 2013, 7:39 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Current trunk Cloudstack does not provision CentOS 6 guest OS type.
> This is because of a minor copy-paste error and an incorrect Guest OS template list.
> While I was at it, I fixed up a few other template types to match the current XenServer
6.1 template list.
> 
> 
> This addresses bug CLOUDSTACK-1620.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java 1b8496f

>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer610Resource.java
17ad3e6 
> 
> Diff: https://reviews.apache.org/r/9839/diff/
> 
> 
> Testing
> -------
> 
> Provisioned CentOS 6 and Ubuntu 12.04 VMs on XS 6.1.
> 
> 
> Thanks,
> 
> Dennis Lawler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message