incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chip Childers" <chip.child...@sungard.com>
Subject Re: Review Request: CLOUDSTACK-1402: listRouters API response doesn't return linklocal IP and public IP details
Date Wed, 06 Mar 2013 18:46:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9784/#review17483
-----------------------------------------------------------

Ship it!


Pushed to 4.1:

commit cbbc488d3c878e95b8155280a220a7fa4262dc8d
Author: Min Chen <min.chen@citrix.com>
Date:   Wed Mar 6 10:11:28 2013 -0800

    CLOUDSTACK-1402: listRouters API response doesn't return linklocal IP and public IP details.

- Chip Childers


On March 6, 2013, 6:16 p.m., Min Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9784/
> -----------------------------------------------------------
> 
> (Updated March 6, 2013, 6:16 p.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> -------
> 
> This patch fixed the blocker defect CLOUDSTACK-1402.
> 
> 
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1402.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/api/query/dao/DomainRouterJoinDaoImpl.java cdb859e 
> 
> Diff: https://reviews.apache.org/r/9784/diff/
> 
> 
> Testing
> -------
> 
> Run listRouters api with the patch, it returns the linkLocal and public IP details along
with guest Ip, see below.
> 
> <listroutersresponse cloud-stack-version="4.1.0-SNAPSHOT"><count>1</count><router><id>160e5c1b-f2f6-4d18-90fc-838b9dca516f</id><zoneid>1547abf3-6805-4a5a-b552-64c56c627e5f</zoneid><zonename>Test
Zone</zonename><dns1>72.52.126.11</dns1><dns2>72.52.126.12</dns2><networkdomain>cs2cloud.internal</networkdomain><gateway>10.223.138.65</gateway><name>r-9-VM</name><podid>e4d59b71-54fa-4da1-8a47-4c268cfe4412</podid><hostid>0ab78594-1326-4093-89ef-3b876afbb9e2</hostid><hostname>Rack3Host12.lab.vmops.com</hostname><linklocalip>169.254.2.164</linklocalip><linklocalmacaddress>0e:00:a9:fe:02:a4</linklocalmacaddress><linklocalnetmask>255.255.0.0</linklocalnetmask><linklocalnetworkid>d98f68de-62c6-4f5b-b135-e2540b475804</linklocalnetworkid><publicip>10.223.138.67</publicip><publicmacaddress>06:18:dc:00:00:0a</publicmacaddress><publicnetmask>255.255.255.192</publicnetmask><publicnetworkid>370174c4-ce3a-4b29-91e0-f0d08b71ef18</publicnetworkid><guestipaddress>10.1.1.1</guestipaddress><guestmacaddress>02:00:1e:d5:00:02</guestmacaddress><guestnetmask>255.255.255.0</guestnetmask><guestnetworkid>54535bed-f40c-4522-b60f-b745c84948f6</guestnetworkid><templateid>c64d8cf4-81dc-11e2-b8cf-066a9a000451</templateid><created>2013-02-28T15:20:29-0800</created><state>Running</state><account>admin</account><domainid>c6276150-81dc-11e2-b8cf-066a9a000451</domainid><domain>ROOT</domain><serviceofferingid>09b00fbc-cfab-460f-8066-0778e48efb8d</serviceofferingid><serviceofferingname>System
Offering For Software Router</serviceofferingname><isredundantrouter>false</isredundantrouter><redundantstate>UNKNOWN</redundantstate><nic><id>2e0a0771-6be9-47a4-a37b-afa11a5e0c5f</id><networkid>54535bed-f40c-4522-b60f-b745c84948f6</networkid><networkname>Test
Network</networkname><netmask>255.255.255.0</netmask><ipaddress>10.1.1.1</ipaddress><isolationuri>vlan://2303</isolationuri><broadcasturi>vlan://2303</broadcasturi><traffictype>Guest</traffictype><type>Isolated</type><isdefault>false</isdefault><macaddress>02:00:1e:d5:00:02</macaddress></nic><nic><id>962d70e4-454c-4e89-9f9f-170e027026a0</id><networkid>370174c4-ce3a-4b29-91e0-f0d08b71ef18</networkid><netmask>255.255.255.192</netmask><gateway>10.223.138.65</gateway><ipaddress>10.223.138.67</ipaddress><isolationuri>vlan://1381</isolationuri><broadcasturi>vlan://1381</broadcasturi><traffictype>Public</traffictype><isdefault>true</isdefault><macaddress>06:18:dc:00:00:0a</macaddress></nic><nic><id>ddec1f87-3af5-4a63-a689-7e004f50ba1b</id><networkid>d98f68de-62c6-4f5b-b135-e2540b475804</networkid><netmask>255.255.0.0</netmask><gateway>169.254.0.1</gateway><ipaddress>169.254.2.164</ipaddress><traffictype>Control</traffictype><isdefault>false</isdefault><macaddress>0e:00:a9:fe:02:a4</macaddress></nic><jobstatus>0</jobstatus></router></listroutersresponse>
> 
> 
> Thanks,
> 
> Min Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message