incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chip Childers <chip.child...@sungard.com>
Subject Re: [DISCUSS] Review Board Guidelines DRAFT
Date Tue, 05 Mar 2013 20:55:44 GMT
On Wed, Feb 27, 2013 at 02:17:50PM -0800, Alex Huang wrote:
> Good point Joe.  I think actually all patches in this manner should be treated as if
it's a merge and go through Chip's merge guidelines.

+1 - added a link.

> 
> --Alex
> 
> > -----Original Message-----
> > From: Joe Brockmeier [mailto:jzb@zonker.net]
> > Sent: Wednesday, February 27, 2013 1:47 PM
> > To: cloudstack-dev@incubator.apache.org
> > Subject: Re: [DISCUSS] Review Board Guidelines DRAFT
> > 
> > On Wed, Feb 27, 2013, at 02:00 PM, Animesh Chaturvedi wrote:
> > > I put together DRAFT review board guidelines in wiki
> > >
> > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+
> > Guidelines.
> > > Please review and update as needed.
> > 
> > I have added a bullet about actually testing patches (not just that it
> > applies) before submitting and indicating what testing has been done.
> > 
> > Best,
> > 
> > jzb
> > --
> > Joe Brockmeier
> > jzb@zonker.net
> > Twitter: @jzb
> > http://www.dissociatedpress.net/
> 

Mime
View raw message