incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcus Sorensen" <shadow...@gmail.com>
Subject Re: Review Request: Document add/remove network on a VM features
Date Mon, 04 Mar 2013 16:35:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9726/#review17338
-----------------------------------------------------------



docs/en-US/add-remove-nic.xml
<https://reviews.apache.org/r/9726/#comment36836>

    User shouldn't have to ensure that the VM is in the same zone as the network. The code
will not allow it. Rather than giving the reader a command to check that the network and vm
are in the same zone, perhaps change this to something that is strictly informative, like
"The network and VM instance must reside in the same zone".
    
    To the list of things to watch out for, we could also add "Two VMs with the same name
cannot reside in the same network. Adding a second VM that duplicates a name on a network
will fail."



docs/en-US/add-remove-nic.xml
<https://reviews.apache.org/r/9726/#comment36835>

    Removing the default NIC is not possible. The way this reads, it sounds like it is warning
the user to not do it.



docs/en-US/add-remove-nic.xml
<https://reviews.apache.org/r/9726/#comment36837>

    We should probably not mention exceptions in the user documentation. This makes it sound
as though there's a bug, when it's most likely an invalid parameter provided or something.
Better to just say "Removing the default NIC is not possible" or something like that. Then
if it fails the user will understand why, but not think it's due to a bug of some sort.



docs/en-US/add-remove-nic.xml
<https://reviews.apache.org/r/9726/#comment36838>

    This probably isn't necessary for the user documentation. If a user tries to remove a
nic that isn't part of the VM, it follows naturally that it will fail.


- Marcus Sorensen


On March 4, 2013, 8:23 a.m., Radhika PC wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9726/
> -----------------------------------------------------------
> 
> (Updated March 4, 2013, 8:23 a.m.)
> 
> 
> Review request for cloudstack, David Nalley, Jessica Tomechak, Joe Brockmeier, and Marcus
Sorensen.
> 
> 
> Description
> -------
> 
> Add /Remove Networks in VMs. Updated the Developer Guide.
> 
> 
> This addresses bug cloudstack-890.
> 
> 
> Diffs
> -----
> 
>   docs/en-US/add-remove-nic.xml PRE-CREATION 
>   docs/en-US/added-API-commands-4-1.xml f635e9d 
>   docs/en-US/whats-new.xml 29ae1f6 
> 
> Diff: https://reviews.apache.org/r/9726/diff/
> 
> 
> Testing
> -------
> 
> Doc builds, patch applies
> 
> 
> Thanks,
> 
> Radhika PC
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message