incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hugo Trippaers" <htrippa...@schubergphilis.com>
Subject Re: Review Request: createSetupGuestNetworkCommand in VpcVirtualNetworkApplianceManagerImpl.java fails when the broadcast URI is not a long
Date Fri, 01 Mar 2013 08:51:46 GMT


> On March 1, 2013, 8:48 a.m., Hugo Trippaers wrote:
> > Ship It!

Fixed whitespace issues

Commit master : 68b836d46db52811dfcbc56619c4a978f54bd515
Commit 4.1 : 5a655e8c755a848b6a8efedc6155e19caae6de93


- Hugo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8701/#review17232
-----------------------------------------------------------


On Dec. 24, 2012, 2:52 a.m., Roeland Kuipers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8701/
> -----------------------------------------------------------
> 
> (Updated Dec. 24, 2012, 2:52 a.m.)
> 
> 
> Review request for cloudstack, Hugo Trippaers and Chiradeep Vittal.
> 
> 
> Description
> -------
> 
> This method expects the broadcast uri to be a long (which is the case for vlan isolation),
but fails when another value is passed into it like the lswitch-guid for Nicira NVP networks.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java 1fd710d

> 
> Diff: https://reviews.apache.org/r/8701/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Roeland Kuipers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message