incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chip Childers <chip.child...@sungard.com>
Subject Re: Review Request: Ensure RAT does not report marvin generated files as noncompliant in developer environment
Date Sat, 02 Mar 2013 13:09:06 GMT
Prasanna,

You asked to move this to 4.1, but is it a blocker or critical fix in your
opinion?  The risk looks low to me. Opinion?

On Mar 2, 2013, at 6:27 AM, Prasanna Santhanam <
Prasanna.Santhanam@citrix.com> wrote:

  This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9707/

On March 2nd, 2013, 11:16 a.m., *Prasanna Santhanam* wrote:

Yes, good to apply. Thanks

 6a1ecae552e8857c8e97c283962d14db4479a9a1 (master)
Pl. cherry-pick to 4.1


- Prasanna

On March 1st, 2013, 9:15 p.m., Chiradeep Vittal wrote:
  Review request for Chip Childers and Prasanna Santhanam.
By Chiradeep Vittal.

*Updated March 1, 2013, 9:15 p.m.*
Description

Ensure RAT does not report marvin generated files as noncompliant in
developer environment

  Testing

mvn clean  install and
mvn --projects=org.apache.cloudstack:cloudstack
org.apache.rat:apache-rat-plugin:0.8:check

  Diffs

   - pom.xml (dde205f6d7cada71fde8ac805394228810a421e2)
   - tools/marvin/marvin/codegenerator.py
   (cce91008dba0b15fa2070daf19f067aa08b86ed6)

View Diff <https://reviews.apache.org/r/9707/diff/>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message