Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 639C1DF22 for ; Fri, 15 Feb 2013 10:58:55 +0000 (UTC) Received: (qmail 24807 invoked by uid 500); 15 Feb 2013 10:58:55 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 24758 invoked by uid 500); 15 Feb 2013 10:58:54 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 24749 invoked by uid 99); 15 Feb 2013 10:58:54 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Feb 2013 10:58:54 +0000 X-ASF-Spam-Status: No, hits=-0.5 required=5.0 tests=FREEMAIL_ENVFROM_END_DIGIT,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of rohityadav89@gmail.com designates 74.125.83.49 as permitted sender) Received: from [74.125.83.49] (HELO mail-ee0-f49.google.com) (74.125.83.49) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Feb 2013 10:58:47 +0000 Received: by mail-ee0-f49.google.com with SMTP id d4so1732549eek.36 for ; Fri, 15 Feb 2013 02:58:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:mime-version:sender:from:date:x-google-sender-auth :message-id:subject:to:cc:content-type; bh=iBsba4KLZYmr8j+sgZY9l2l/7JLIYxJHS1ja6Axq5p4=; b=elWYd6uphe46AfxXiMQzM5uRnxFyQ3W2wSsElkumATBtPklGvgrduykJ5jTVhpcZK3 9W2TO6NGseCDRAVS1eUuRrJZwNMiHis4GIr67DQgnI4QyOBNR6EZ21PL3L07X5HM3zAB LELnbB1N8ErSIXyxS0My+dN44MVPAdUJ17e6XOeNRVEM3VQdK14E2ssKfz2PvyGgc6Ok sMO7cTu5hz5VZm71HCrqVB2d+WwBTdXtVwRMLDxvM4G3jyNTB+AW4PCWi92SBWk6WB6W V8TSSz/UOp5NNuORqX4jUD49wBIAtKFL3hLuIE7O/teAhUtpE30WnAZF7dL0dNE22MkR W8uQ== X-Received: by 10.14.184.68 with SMTP id r44mr7010743eem.40.1360925906845; Fri, 15 Feb 2013 02:58:26 -0800 (PST) MIME-Version: 1.0 Sender: rohityadav89@gmail.com Received: by 10.223.4.154 with HTTP; Fri, 15 Feb 2013 02:58:06 -0800 (PST) From: Rohit Yadav Date: Fri, 15 Feb 2013 16:28:06 +0530 X-Google-Sender-Auth: BEis_k1wc-YMLDpOBUjbDAWO6nQ Message-ID: Subject: Merge 4.1-new-db-schema.sql to db/db/schema-40to410.sql To: Edison Su , cloudstack-dev@incubator.apache.org Cc: Sheng Yang , Alex Huang , Kishan Kavala , Min Chen Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Checked: Checked by ClamAV on apache.org Edison, you'd created a 4.1-new-db-schema sql, may I merge 4.1-new-db-schema.sql to db/db/schema-40to410.sql? We'll also need a db/db/schema-40to410-cleanup.sql and upgrading class. There is some difference between the 4.0 create-schema.sql and that in 4.1: http://people.apache.org/~bhaisaab/diff-create-schema-40-41.sql Alex suggested in last discussion that we should not change the schema file and have upgrade paths and cleanup paths. This would help us do rolling upgrades. But Alex, there are a lot of difference between the 4.0 schema and 4.1 schema sqls (about 4k lines of diff): http://people.apache.org/~bhaisaab/diff4041sqls.sql If we don't want developers to change anything in the schema files, how do you propose we fix it now for 4.1? Move all these changes to 40to41 sql? Sheng (ipv6), Kishan (regions), Vijay (autoscale) I see some create schema changes, should we move them to db/db/schema-40to410.sql? Min, the create-schema-view did not exist for 4.0, should we keep it as it as, our move it as upgrade path? For 4.1, we should do following changes so DatabaseCreator could be refactored and used starting 4.2/master: - Change version to 4.0 in create-schema - Make sure there is difference between 4.0 and 4.1 create-schema sqls - Move new additions to db/db/schema-40to410.sql, define a cleanup path/sql and upgrading class from 40-41 - Fix cloudstack-setup-databases, for 4.1 we won't use databasecreator, stick with the present script (won't risk regressions and whatnot) Regards.