Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (nike.apache.org: local policy)
From: Hugo Trippaers <HTrippaers@schubergphilis.com>
To: "cloudstack-dev@incubator.apache.org"
	<cloudstack-dev@incubator.apache.org>, "'bhaisaab@apache.org'"
	<bhaisaab@apache.org>
Subject: FW: [1/2] git commit: refs/heads/4.1 - CLOUDSTACK-1226: Fix
 4.1-new-db-schema.sql, use cloud before exec statements
Thread-Topic: [1/2] git commit: refs/heads/4.1 - CLOUDSTACK-1226: Fix
 4.1-new-db-schema.sql, use cloud before exec statements
Thread-Index: AQHOCEjPC8vhKR778UK/xpVYx+VSG5h01oUQ
Date: Mon, 11 Feb 2013 16:21:54 +0000
Message-ID: <6DE00C9FDF08A34683DF71786C70EBF02F6C1BBE@SBPOMB402.sbp.lan>
References: <20130211111322.8E3553C794@tyr.zones.apache.org>
In-Reply-To: <20130211111322.8E3553C794@tyr.zones.apache.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Hey Rohit,

I don't think this is the right solution, we should not depend on the name =
of the database in the scripts themselves. All the other scripts use the pr=
efix 'cloud.' to work around this. I would prefer it that way so admins can=
 change stuff without have to go through the database scripts, like reading=
 stuff into a test database.

Cheers,

Hugo

> -----Original Message-----
> From: bhaisaab@apache.org [mailto:bhaisaab@apache.org]
> Sent: Monday, February 11, 2013 12:13 PM
> To: cloudstack-commits@incubator.apache.org
> Subject: [1/2] git commit: refs/heads/4.1 - CLOUDSTACK-1226: Fix 4.1-new-
> db-schema.sql, use cloud before exec statements
>=20
> CLOUDSTACK-1226: Fix 4.1-new-db-schema.sql, use cloud before exec
> statements
>=20
> Signed-off-by: Rohit Yadav <bhaisaab@apache.org>
>=20
>=20
> Project: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/repo
> Commit: http://git-wip-us.apache.org/repos/asf/incubator-
> cloudstack/commit/e3156a6e
> Tree: http://git-wip-us.apache.org/repos/asf/incubator-
> cloudstack/tree/e3156a6e
> Diff: http://git-wip-us.apache.org/repos/asf/incubator-
> cloudstack/diff/e3156a6e
>=20
> Branch: refs/heads/4.1
> Commit: e3156a6e16cee9ffeb5d757dd8a775236127410f
> Parents: a880f47
> Author: Rohit Yadav <bhaisaab@apache.org>
> Authored: Mon Feb 11 16:36:41 2013 +0530
> Committer: Rohit Yadav <bhaisaab@apache.org>
> Committed: Mon Feb 11 16:42:48 2013 +0530
>=20
> ----------------------------------------------------------------------
>  setup/db/4.1-new-db-schema.sql |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> ----------------------------------------------------------------------
>=20
>=20
> http://git-wip-us.apache.org/repos/asf/incubator-
> cloudstack/blob/e3156a6e/setup/db/4.1-new-db-schema.sql
> ----------------------------------------------------------------------
> diff --git a/setup/db/4.1-new-db-schema.sql b/setup/db/4.1-new-db-
> schema.sql index e8bafa2..d60eca2 100644
> --- a/setup/db/4.1-new-db-schema.sql
> +++ b/setup/db/4.1-new-db-schema.sql
> @@ -15,6 +15,8 @@
>  -- specific language governing permissions and limitations
>  -- under the License.
>=20
> +use cloud;
> +
>  alter table vm_template add image_data_store_id bigint unsigned;  alter
> table vm_template add size bigint unsigned;  alter table vm_template add
> state varchar(255);