Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 26D41E8C2 for ; Tue, 26 Feb 2013 07:47:16 +0000 (UTC) Received: (qmail 35209 invoked by uid 500); 26 Feb 2013 07:47:15 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 34860 invoked by uid 500); 26 Feb 2013 07:47:15 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 34838 invoked by uid 99); 26 Feb 2013 07:47:15 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Feb 2013 07:47:15 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 08B681C776E; Tue, 26 Feb 2013 07:47:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2880160886834874210==" MIME-Version: 1.0 Subject: Re: Review Request: CLOUDSTACK-1156: Limit Primary and Secondary storage for domain/accounts From: "Sanjay Tripathi" To: "mice xia" , "Min Chen" , "Devdeep Singh" Cc: "Sateesh Chodapuneedi" , "cloudstack" , "Sanjay Tripathi" Date: Tue, 26 Feb 2013 07:47:06 -0000 Message-ID: <20130226074706.1280.5887@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Sanjay Tripathi" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/9541/ X-Sender: "Sanjay Tripathi" References: <20130225124704.1280.9544@reviews.apache.org> In-Reply-To: <20130225124704.1280.9544@reviews.apache.org> Reply-To: "Sanjay Tripathi" --===============2880160886834874210== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9541/ ----------------------------------------------------------- (Updated Feb. 26, 2013, 7:47 a.m.) Review request for cloudstack, Devdeep Singh, mice xia, and Min Chen. Changes ------- Updated diff as per review comments. Description ------- CLOUDSTACK-1156: Limit Primary and Secondary storage for domain/accounts = Addition of two new resource types i.e. Primary and Secondary storage s= pace in the existing pool of resource types. Added methods to set the limits on these resources using updateResource= Limit API command and to get a count using updateResourceCount. Also added ca= lls in the Templates, Volumes, Snapshots life cycle to check these limits and to i= ncrement/decrement the new resource types = Resource Name :: Resource type number Primary Storage 10 Secondary Storage 11 = Also added jUnit Tests for the same. This addresses bug CLOUDSTACK-1156. Diffs (updated) ----- api/src/com/cloud/configuration/Resource.java 7614c8a = api/src/com/cloud/storage/VolumeApiService.java 8517988 = api/src/org/apache/cloudstack/api/command/user/resource/UpdateResourceCou= ntCmd.java f6d3a98 = api/src/org/apache/cloudstack/api/command/user/resource/UpdateResourceLim= itCmd.java 0039f62 = api/src/org/apache/cloudstack/api/command/user/volume/ResizeVolumeCmd.jav= a 955727a = api/src/org/apache/cloudstack/api/response/AccountResponse.java 9a98a35 = api/src/org/apache/cloudstack/api/response/ResourceCountResponse.java a7f= bbf2 = api/src/org/apache/cloudstack/api/response/ResourceLimitResponse.java b44= 4e7a = server/src/com/cloud/api/ApiResponseHelper.java eafee8a = server/src/com/cloud/api/query/dao/AccountJoinDaoImpl.java 898bafc = server/src/com/cloud/api/query/vo/AccountJoinVO.java cd7231c = server/src/com/cloud/baremetal/BareMetalTemplateAdapter.java 0cf19fb = server/src/com/cloud/configuration/Config.java eb6fb24 = server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java 7ff06af = server/src/com/cloud/storage/VolumeManager.java af3cbbf = server/src/com/cloud/storage/VolumeManagerImpl.java a69607f = server/src/com/cloud/storage/dao/SnapshotDao.java 0e378a7 = server/src/com/cloud/storage/dao/SnapshotDaoImpl.java 5b3f273 = server/src/com/cloud/storage/dao/VolumeDao.java d7a2667 = server/src/com/cloud/storage/dao/VolumeDaoImpl.java ca3b82a = server/src/com/cloud/storage/download/DownloadMonitorImpl.java 0bc89e3 = server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java ed48bd1 = server/src/com/cloud/template/HyervisorTemplateAdapter.java ad41af5 = server/src/com/cloud/template/TemplateManagerImpl.java 29659d3 = server/src/com/cloud/vm/UserVmManagerImpl.java c2bba63 = server/test/com/cloud/resourcelimit/ResourceLimitManagerImplTest.java d31= 1ad3 = server/test/com/cloud/vpc/MockResourceLimitManagerImpl.java b9fc861 = setup/db/db/schema-40to410.sql 59b2a7d = setup/db/db/schema-410to420.sql 6c831f0 = utils/src/com/cloud/utils/UriUtils.java a8b5ccb = Diff: https://reviews.apache.org/r/9541/diff/ Testing ------- Tested life cycle of templates, volumes, snapshots, vm on my local CloudSta= ck setup. Thanks, Sanjay Tripathi --===============2880160886834874210==--