Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AA270E8A1 for ; Tue, 19 Feb 2013 16:19:29 +0000 (UTC) Received: (qmail 23939 invoked by uid 500); 19 Feb 2013 16:19:29 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 23904 invoked by uid 500); 19 Feb 2013 16:19:29 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 23651 invoked by uid 99); 19 Feb 2013 16:19:26 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Feb 2013 16:19:26 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 02BCC1C7878; Tue, 19 Feb 2013 16:19:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7452892751686955318==" MIME-Version: 1.0 Subject: Re: Review Request: multiple ip address per vm nic changes for isolated and vpc networks changes. From: "Jayapal Reddy" To: "Chip Childers" , "cloudstack" , "David Nalley" , "Jayapal Reddy" Date: Tue, 19 Feb 2013 16:19:19 -0000 Message-ID: <20130219161919.18986.51095@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jayapal Reddy" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/9396/ X-Sender: "Jayapal Reddy" References: <20130210091221.21521.91579@reviews.apache.org> In-Reply-To: <20130210091221.21521.91579@reviews.apache.org> Reply-To: "Jayapal Reddy" --===============7452892751686955318== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9396/ ----------------------------------------------------------- (Updated Feb. 19, 2013, 4:19 p.m.) Review request for cloudstack. Changes ------- Added unit test cases and updated the sql file in the new patch Description ------- Using this feature we can reserve secondary ip addresses for guest vm nic. Administrator will configure the these ip addresses on the nic manually. This addresses bug CLOUDSTACK-24. Diffs (updated) ----- api/src/com/cloud/network/IpAddress.java 47df4d6 = api/src/com/cloud/network/NetworkService.java ace1bb6 = api/src/com/cloud/network/rules/RulesService.java 921a86e = api/src/com/cloud/vm/Nic.java 9d21130 = api/src/com/cloud/vm/NicSecondaryIp.java PRE-CREATION = api/src/org/apache/cloudstack/api/ApiConstants.java cd7d700 = api/src/org/apache/cloudstack/api/ResponseGenerator.java 267238a = api/src/org/apache/cloudstack/api/command/user/firewall/CreatePortForward= ingRuleCmd.java 39ab812 = api/src/org/apache/cloudstack/api/command/user/nat/EnableStaticNatCmd.jav= a ce6ea16 = api/src/org/apache/cloudstack/api/command/user/vm/AddIpToVmNicCmd.java PR= E-CREATION = api/src/org/apache/cloudstack/api/command/user/vm/ListNicsCmd.java PRE-CR= EATION = api/src/org/apache/cloudstack/api/command/user/vm/ListSecondaryIPToNicCmd= .java PRE-CREATION = api/src/org/apache/cloudstack/api/command/user/vm/RemoveIpFromVmNicCmd.ja= va PRE-CREATION = api/src/org/apache/cloudstack/api/command/user/vm/RemoveNicFromVMCmd.java= b1a870e = api/src/org/apache/cloudstack/api/response/AddIpToVmNicResponse.java PRE-= CREATION = api/src/org/apache/cloudstack/api/response/IPAddressResponse.java 251b2dd = api/src/org/apache/cloudstack/api/response/ListNicSecondaryIpResponse.jav= a PRE-CREATION = api/src/org/apache/cloudstack/api/response/NicResponse.java a7d1a0d = api/test/org/apache/cloudstack/api/command/test/AddIpToVmNicTest.java PRE= -CREATION = client/tomcatconf/commands.properties.in e1d0fb2 = server/src/com/cloud/api/ApiDBUtils.java e6b1bf1 = server/src/com/cloud/api/ApiResponseHelper.java a94e935 = server/src/com/cloud/network/NetworkManager.java 2904183 = server/src/com/cloud/network/NetworkManagerImpl.java f586865 = server/src/com/cloud/network/NetworkModelImpl.java beebb87 = server/src/com/cloud/network/NetworkServiceImpl.java 37b4903 = server/src/com/cloud/network/addr/PublicIp.java 7336c9c = server/src/com/cloud/network/dao/IPAddressDao.java 9cdb975 = server/src/com/cloud/network/dao/IPAddressDaoImpl.java e7067d9 = server/src/com/cloud/network/dao/IPAddressVO.java 00da5eb = server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.ja= va 1abca51 = server/src/com/cloud/network/rules/RulesManagerImpl.java 614d308 = server/src/com/cloud/network/rules/dao/PortForwardingRulesDao.java 91f08e= 7 = server/src/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java 54= 06ab6 = server/src/com/cloud/server/ManagementServerImpl.java d381206 = server/src/com/cloud/vm/NicVO.java 8e2edda = server/src/com/cloud/vm/UserVmManagerImpl.java df97609 = server/src/com/cloud/vm/dao/NicDao.java 762048b = server/src/com/cloud/vm/dao/NicDaoImpl.java 5cf152f = server/src/com/cloud/vm/dao/NicSecondaryIpDao.java PRE-CREATION = server/src/com/cloud/vm/dao/NicSecondaryIpDaoImpl.java PRE-CREATION = server/src/com/cloud/vm/dao/NicSecondaryIpVO.java PRE-CREATION = server/test/com/cloud/network/MockNetworkManagerImpl.java 4a24f9a = server/test/com/cloud/network/MockRulesManagerImpl.java ba3dd41 = server/test/com/cloud/vpc/MockNetworkManagerImpl.java bcaaa26 = setup/db/db/schema-410to420.sql 65add75 = Diff: https://reviews.apache.org/r/9396/diff/ Testing ------- Tested add adding, deleting and listing addresses on the nic using APIs Thanks, Jayapal Reddy --===============7452892751686955318==--