Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1AD95E24B for ; Tue, 19 Feb 2013 06:41:10 +0000 (UTC) Received: (qmail 4619 invoked by uid 500); 19 Feb 2013 06:41:09 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 4296 invoked by uid 500); 19 Feb 2013 06:41:09 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 4269 invoked by uid 99); 19 Feb 2013 06:41:09 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Feb 2013 06:41:09 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 944BD1C532E; Tue, 19 Feb 2013 06:41:01 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0712350552670767410==" MIME-Version: 1.0 Subject: Re: Review Request: PATCH-4 for feature VMware vNetwork Distributed Virtual Switch support in CloudStack From: "Sateesh Chodapuneedi" To: "Murali Reddy" , "Kelven Yang" Cc: "Koushik Das" , "cloudstack" , "Sateesh Chodapuneedi" , "ilya musayev" Date: Tue, 19 Feb 2013 06:41:01 -0000 Message-ID: <20130219064101.18987.9060@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Sateesh Chodapuneedi" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/9201/ X-Sender: "Sateesh Chodapuneedi" References: <20130213040456.21521.98667@reviews.apache.org> In-Reply-To: <20130213040456.21521.98667@reviews.apache.org> Reply-To: "Sateesh Chodapuneedi" --===============0712350552670767410== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9201/ ----------------------------------------------------------- (Updated Feb. 19, 2013, 6:41 a.m.) Review request for cloudstack, Murali Reddy and Kelven Yang. Description ------- This is 4th patch for feature 'Support for VMware dvSwitch in CloudStack'. This patch contains, test cases and changes to prepareNetwork function to c= onsider vmware dvswitch as well. Trying to create new dv port group if not = alreayd present and update in case of modification of dvportgroup shaping p= olicy. This addresses bug CLOUDSTACK-657. Diffs (updated) ----- vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java = 50f9541 = vmware-base/test/com/cloud/vmware/TestVMWare.java 43c784c = Diff: https://reviews.apache.org/r/9201/diff/ Testing ------- Manual testing:- 1) Tested guest traffic over dvSwitch on a dedicated physical network. In t= his case management and public traffic uses standard vSwitch on a common ph= ysical network. 2) Tested both guest traffic and public traffic over dvSwitch on a physical= network. 3) Use optional parameters added to AddClusterCmd to override Zone level ne= twork traffic label. Tested 2 clusters, one with standard vSwitch and other= with dvSwitch. 4) Tested all 3 traffic types on single physical network with global parame= ter 'vmware.use.dvswitch' set to false. This is default configuration scena= rio. Added following tests, 1) Test fetching dvSwitch object from vCenter 2) Test for presence of dvPortGroup 3) Test presence of dvPortGroup 4) Test get existing dvPortGroup 5) fetch dvPortGroup configuration 6) Test compare dvPortGroup configuration 7) Test update dvPortGroup configuration Thanks, Sateesh Chodapuneedi --===============0712350552670767410==--