Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AEA44E59A for ; Wed, 13 Feb 2013 06:18:56 +0000 (UTC) Received: (qmail 55074 invoked by uid 500); 13 Feb 2013 06:18:56 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 54931 invoked by uid 500); 13 Feb 2013 06:18:56 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 54916 invoked by uid 99); 13 Feb 2013 06:18:55 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Feb 2013 06:18:55 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9890E1C7376; Wed, 13 Feb 2013 06:18:48 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7981179250966857700==" MIME-Version: 1.0 Subject: Re: Review Request: [EC2 Query API] DescribeSnapshots, 'n' ListVolumes get fired on CS for displaying 'n' Snapshots taken from the same Volume From: "Likitha Shetty" To: "Prachi Damle" Cc: "cloudstack" , "Likitha Shetty" Date: Wed, 13 Feb 2013 06:18:48 -0000 Message-ID: <20130213061848.21521.42807@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Likitha Shetty" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/9247/ X-Sender: "Likitha Shetty" References: <20130201112202.24984.19845@reviews.apache.org> In-Reply-To: <20130201112202.24984.19845@reviews.apache.org> Reply-To: "Likitha Shetty" --===============7981179250966857700== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9247/ ----------------------------------------------------------- (Updated Feb. 13, 2013, 6:18 a.m.) Review request for cloudstack and Prachi Damle. Changes ------- Prachi, i have updated the diff. I have verified that it cleanly applies on= master. I have also updated the diff to use containsKey method of the HashMap inste= ad of iterating through the Map with iterator. Description ------- For snapshots taken from the same volume re-use the response obtained by ca= lling listVolumes This addresses bug CLOUDSTACK-1134. Diffs (updated) ----- awsapi/src/com/cloud/bridge/service/EC2SoapServiceImpl.java 9fc581b = awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java a835d8a = Diff: https://reviews.apache.org/r/9247/diff/ Testing ------- 1. Create multiple snapshots from the same volume 2. Run ec2_get_all_snapshots - check CS api.log to ensure listVolumes has b= een called just once for every volume Thanks, Likitha Shetty --===============7981179250966857700==--