Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CBAA1EBA0 for ; Tue, 12 Feb 2013 22:47:46 +0000 (UTC) Received: (qmail 2848 invoked by uid 500); 12 Feb 2013 22:47:46 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 2807 invoked by uid 500); 12 Feb 2013 22:47:46 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 2796 invoked by uid 99); 12 Feb 2013 22:47:46 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Feb 2013 22:47:46 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BC8F21C74A6; Tue, 12 Feb 2013 22:47:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0958471119723829611==" MIME-Version: 1.0 Subject: Re: Review Request: [EC2 Query API] AuthorizeSecurityGroupIngress and RevokeSecurityGroupIngress fails when icmp code and type is provided From: "Prachi Damle" To: "Prachi Damle" Cc: "cloudstack" , "Likitha Shetty" Date: Tue, 12 Feb 2013 22:47:38 -0000 Message-ID: <20130212224738.21521.67214@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Prachi Damle" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/9251/ X-Sender: "Prachi Damle" References: <20130201113929.24984.23181@reviews.apache.org> In-Reply-To: <20130201113929.24984.23181@reviews.apache.org> Reply-To: "Prachi Damle" --===============0958471119723829611== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9251/#review16489 ----------------------------------------------------------- Ship it! Looks fine. Commit hash: c3be0f995d1b3f5ee1355971143234871ad517d9 - Prachi Damle On Feb. 1, 2013, 11:39 a.m., Likitha Shetty wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9251/ > ----------------------------------------------------------- > = > (Updated Feb. 1, 2013, 11:39 a.m.) > = > = > Review request for cloudstack and Prachi Damle. > = > = > Description > ------- > = > For AuthorizeSecurityGroupIngress RevokeSecurityGroupIngress query calls = parse and set the icmp code and type > = > = > This addresses bug CLOUDSTACK-1135. > = > = > Diffs > ----- > = > awsapi/src/com/cloud/bridge/service/EC2RestServlet.java 78e736f = > = > Diff: https://reviews.apache.org/r/9251/diff/ > = > = > Testing > ------- > = > 1. Create a security group > 2. Create a rule with conn.authorize_security_group and specify the ip_pr= otocol as 'icmp' and 'from_port' and 'to_port' as -1 - The rule should be s= uccessfully created = > = > = > Thanks, > = > Likitha Shetty > = > --===============0958471119723829611==--