Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============3255770836158356022=="
MIME-Version: 1.0
Subject: Re: Review Request: CLOUDSTACK-357 ISOs can be deleted while still
 attached
 to a running VM, and they subsequently cannot be detached from a running VM
From: "deepti dohare" <deepti.dohare@citrix.com>
To: "cloudstack" <cloudstack-dev@incubator.apache.org>,
 "deepti dohare" <deepti.dohare@citrix.com>
Date: Fri, 01 Feb 2013 07:37:05 -0000
Message-ID: <20130201073705.24984.9767@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "deepti dohare" <noreply@reviews.apache.org>
References: <20121019072557.16968.44508@reviews.apache.org>
In-Reply-To: <20121019072557.16968.44508@reviews.apache.org>
Reply-To: "deepti dohare" <deepti.dohare@citrix.com>

--===============3255770836158356022==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7660/
-----------------------------------------------------------

(Updated Feb. 1, 2013, 7:37 a.m.)


Review request for cloudstack.


Changes
-------

Resubmitting the patch with new changes.


Description
-------

Currently no warning or confirmation is given or required to delete an iso =
which is attached to a virtual machine.

Fixing this issue using =E2=80=9Cforce=E2=80=9D delete option.
If an admin or a user deletes an ISO which is attached to a vm:
1. Without force option; gives a warning that ISO is attached to vm =E2=80=
=9CFailed to delete iso. It is currently attached to virtual machine. Pleas=
e detach it before deleting=E2=80=9D.
2. With force option: first detach the ISO from all vms and then deletes th=
e ISO. =


This addresses bug CLOUDSTACK-357.


Diffs (updated)
-----

  api/src/org/apache/cloudstack/api/command/user/iso/DeleteIsoCmd.java 4c37=
0c7 =

  server/src/com/cloud/template/TemplateManagerImpl.java 42106b3 =

  server/src/com/cloud/vm/dao/UserVmDao.java 9fbcde3 =

  server/src/com/cloud/vm/dao/UserVmDaoImpl.java db1d877 =

  ui/scripts/templates.js 040ce4a =


Diff: https://reviews.apache.org/r/7660/diff/


Testing
-------

Verified locally. Tested for some cases:

1. Deleting iso(not attached to any vm)
2. Deleting iso(attached to multiple vms in same domain)
3. Deleting iso(attached to multiple vms in different domains)

For admin/user


Thanks,

deepti dohare


--===============3255770836158356022==--