Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C751BE4ED for ; Fri, 1 Feb 2013 06:03:47 +0000 (UTC) Received: (qmail 83239 invoked by uid 500); 1 Feb 2013 06:03:47 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 83207 invoked by uid 500); 1 Feb 2013 06:03:46 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 83181 invoked by uid 99); 1 Feb 2013 06:03:45 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Feb 2013 06:03:45 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4A5451C6F1D; Fri, 1 Feb 2013 06:03:39 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0526906685910065833==" MIME-Version: 1.0 Subject: Re: Review Request: [EC2 Query API] Improve the logging. Having empty response objects is harmless to functionality From: "Likitha Shetty" To: "Prachi Damle" Cc: "cloudstack" , "Likitha Shetty" Date: Fri, 01 Feb 2013 06:03:39 -0000 Message-ID: <20130201060339.24984.11761@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Likitha Shetty" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/9228/ X-Sender: "Likitha Shetty" References: <20130201060252.24984.55159@reviews.apache.org> In-Reply-To: <20130201060252.24984.55159@reviews.apache.org> Reply-To: "Likitha Shetty" --===============0526906685910065833== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9228/ ----------------------------------------------------------- (Updated Feb. 1, 2013, 6:03 a.m.) Review request for cloudstack and Prachi Damle. Summary (updated) ----------------- [EC2 Query API] Improve the logging. Having empty response objects is harml= ess to functionality Description (updated) ------- This is observed in the awsapi.log for all Describe* EC2 commands when the = response object returned by CS has no elements. But with EC2DescribeImages = command it is always observed. This is because every time DescribeImage is = fired, we call CS listTemplates command multiple times, each time setting a= different value for the templateFilter parameter (e.g. featured, executabl= e, community etc.). And for some of these CS calls made we obtain am empty = response and hence the message in the logs. = This addresses bug CLOUDSTACK-1124. Diffs ----- awsapi/src/com/cloud/stack/CloudStackClient.java 5002aa5 = Diff: https://reviews.apache.org/r/9228/diff/ Testing ------- Using boto, call get_all_images - awsapi.log should not contain 'Unable to = find responseObjName:[template]. Returning null! Exception: Property listte= mplatesresponse.template is resolved to null JSON element on object: {"list= templatesresponse":{}} ' Thanks, Likitha Shetty --===============0526906685910065833==--