incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Musayev, Ilya" <imusa...@webmd.net>
Subject RE: Review Request: patch-3 for feature 'Support for VMware dvSwitch in CloudStack'.
Date Wed, 06 Feb 2013 00:39:51 GMT
Please disregard, I realized I was missing the other 4 patches out of 5.

FYI, patch 2 did not apply cleanly to current master branch and had to be done manually.

Thanks,

Regards
ilya

-----Original Message-----
From: Musayev, Ilya [mailto:imusayev@webmd.net] 
Sent: Tuesday, February 05, 2013 3:18 PM
To: cloudstack-dev@incubator.apache.org; Koushik Das; Murali Reddy; Kelven Yang
Cc: Sateesh Chodapuneedi
Subject: RE: Review Request: patch-3 for feature 'Support for VMware dvSwitch in CloudStack'.

Sateesh,

Dont know if it makes a difference, but i went ahead and pulled the patch of review board
to try it out.

My maven build failed like so:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile
(default-compile) on project cloud-plugin-hypervisor-vmware: Compilation failure: Compilation
failure:
[ERROR] VmwareTrafficLabel.java:[50,48] cannot find symbol [ERROR] symbol  : method getType(java.lang.String)
[ERROR] location: class com.cloud.hypervisor.vmware.mo.VirtualSwitchType
[ERROR] VmwareTrafficLabel.java:[53,32] cannot find symbol [ERROR] symbol  : variable None
[ERROR] location: class com.cloud.hypervisor.vmware.mo.VirtualSwitchType
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile
(default-compile) on project cloud-plugin-hypervisor-vmware: Compilation failure


What am i missing?

Thanks
ilya


________________________________________
From: Koushik Das [noreply@reviews.apache.org] on behalf of Koushik Das [koushik.das@citrix.com]
Sent: Tuesday, February 05, 2013 3:17 AM
To: Murali Reddy; Kelven Yang
Cc: Sateesh Chodapuneedi; cloudstack; Koushik Das
Subject: Re: Review Request: patch-3 for feature 'Support for VMware dvSwitch in CloudStack'.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9196/#review16096
-----------------------------------------------------------



vmware-base/src/com/cloud/hypervisor/vmware/mo/DatacenterMO.java
<https://reviews.apache.org/r/9196/#comment34427>

    Not used



vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualSwitchType.java
<https://reviews.apache.org/r/9196/#comment34430>

    Make vmwaredvs, nexusdvs, vmwaresvs as constants


- Koushik Das


On Feb. 5, 2013, 5:41 a.m., Sateesh Chodapuneedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9196/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2013, 5:41 a.m.)
>
>
> Review request for cloudstack, Murali Reddy and Kelven Yang.
>
>
> Description
> -------
>
> This is 3rd patch for feature 'Support for VMware dvSwitch in CloudStack'.
> This patch contains few helper functions (get dvswitch reference, check the type of a
port group). Also added method getType() to VirtualSwitchType enum.
>
>
> This addresses bug CLOUDSTACK-657.
>
>
> Diffs
> -----
>
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/DatacenterMO.java eb10e16
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualSwitchType.java d6226ff
>   vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java 
> 47ff8e2
>
> Diff: https://reviews.apache.org/r/9196/diff/
>
>
> Testing
> -------
>
> Manual testing:-
> 1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management
and public traffic uses standard vSwitch on a common physical network.
> 2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
> 3) Use optional parameters added to AddClusterCmd to override Zone level network traffic
label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
> 4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch'
set to false. This is default configuration scenario.
>
>
> Added following tests,
> 1) Test fetching dvSwitch object from vCenter
> 2) Test for presence of dvPortGroup
> 3) Test presence of dvPortGroup
> 4) Test get existing dvPortGroup
> 5) fetch dvPortGroup configuration
> 6) Test compare dvPortGroup configuration
> 7) Test update dvPortGroup configuration
>
>
> Thanks,
>
> Sateesh Chodapuneedi
>
>




Mime
View raw message