incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhinandan Prateek <Abhinandan.Prat...@citrix.com>
Subject Re: Your commit d37ed18c3aff4fe522adb803322ba912819c73da placed scripts folder in a wrong place in master
Date Wed, 27 Feb 2013 04:43:54 GMT
I think this change was made as on VMWare the CS was not able to create a
mount point for copying system VM templates ?
Is this one fixed with the latest commit ?

-abhi

On 27/02/13 4:42 AM, "Min Chen" <min.chen@citrix.com> wrote:

>Hi Rohit,
>
>In syncing with master with my feature branch vim51_win8, I filed this
>bug https://issues.apache.org/jira/browse/CLOUDSTACK-1387, mvn build
>failed to copy scripts folder under
>"client/target/cloud-client-ui-4.2.0-SNAPSHOT/WEB-INF". Edison checked in
>a fix to master and correctly addressed the problem. Today when I rebased
>with master again, this is broken again due to your recent commit
>d37ed18c3aff4fe522adb803322ba912819c73da. First, I noticed that you have
>reverted Edison's commit to explicitly create a directory, any reason for
>that? By moving copying scripts after mvn copy, it can be guaranteed that
>the directory already exists. Secondly, your fix is not correct, which
>will place a nested scripts folder under
>"client/target/cloud-client-ui-4.2.0-SNAPSHOT/WEB-INF/scripts". To
>unblock myself from testing vmware, I have checked in
>cf06861c9bf883f2ca1ec818fe7bd4ad26b84318 to address this issue.
>
>Thanks
>-min
>


Mime
View raw message