incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Min Chen <min.c...@citrix.com>
Subject Re: [DISCUSS]Upgrade Vmware SDK to 5.1 to support Windows 8 and Windows 2012 as VM guest OS on vmware
Date Fri, 22 Feb 2013 21:25:33 GMT
Thanks, Chip and Alex. I will share the integration tests I have done and
results before merging notification.

-min

On 2/22/13 12:34 PM, "Chip Childers" <chip.childers@sungard.com> wrote:

>On Fri, Feb 22, 2013 at 11:39:57AM -0800, Alex Huang wrote:
>> My opinion is that we have a test driver that tests all hypervisor
>>resources.  The hypervisor resources are really just translation layers
>>so a test driver that sends out different start commands and have it
>>configure against the hardware makes sense to me.
>> 
>
>+1
>
>And in this case, Min is right.  Unit tests are the wrong tests for now.
>
>Min, can you instead share your integration tests and results before
>merging?  I think that will help achieve the intended result.
>
>-chip
>
>> --Alex
>> 
>> > -----Original Message-----
>> > From: Min Chen [mailto:min.chen@citrix.com]
>> > Sent: Friday, February 22, 2013 11:26 AM
>> > To: cloudstack-dev@incubator.apache.org
>> > Subject: Re: [DISCUSS]Upgrade Vmware SDK to 5.1 to support Windows 8
>> > and Windows 2012 as VM guest OS on vmware
>> > 
>> > Thanks for nice feedback.
>> > 
>> > Regarding Hugo's comment on generating our own proxy-classes, it is
>>tracked
>> > in a separate JIRA ticket
>> > (https://issues.apache.org/jira/browse/CLOUDSTACK-715), which will be
>>the
>> > future goal. But for the immediate support of Windows 8/2012 in 4.2,
>>we
>> > chose to first support 5.1 SDK.
>> > 
>> > Regarding unit testing, I personally feel that it is not quite
>>applicable here
>> > since the change is specifically related to how our cloudstack will
>> > communicate to a Vcenter. Without a real Vcenter running, unit
>>testing will
>> > not be useful that much in my personal opinion. Of course, we can
>>mock all
>> > the api response from Vcenter WS call, but this will be a too big
>>scope to
>> > mock all those Vcenter object structures without much real value
>>here. That
>> > is why I mainly focused on integration testing here against a real
>>Vcenter 5.1,
>> > unfortunately that part is still done manually currently. For
>>XenServer
>> > hypervisor, we at least can write marvin automated test against
>>devcloud.
>> > We don't have such an option for vmware.
>> > Any suggestions?
>> > 
>> > Thanks
>> > -min
>> > 
>> > 
>> > 
>> > On 2/22/13 6:23 AM, "Chip Childers" <chip.childers@sungard.com> wrote:
>> > 
>> > >On Fri, Feb 22, 2013 at 09:20:53AM +0000, Hugo Trippaers wrote:
>> > >> Hey Min,
>> > >>
>> > >> Nice job :-) Is there any change in licensing for the new SDK? We
>> > >>still have an issue with the distribution of the vmware stuff, I
>> > >>believe we also discussed moving to a more redistributable version
>>of
>> > >>the vmware SDK (can't remember the name though), might it not be a
>> > >>good idea to put that in as well now?
>> > >>
>> > >
>> > >+1 to this being a nice job.  It's a shame that we didn't generate
>>out
>> > >own proxy-classes from the WSDL, but getting 5.1 support is a good
>> > >thing.
>> > >
>> > >> As discussed in other threads as well, can you explain what you put
>> > >>into this feature branch with regards to automated testing? I'm
>> > >>particularly interested in the unit tests you put in to verify any
>> > >>changed parts of the code. If you want I can put a build job on this
>> > >>feature branch so we get the code coverage output and the unittest
>> > >>overview automagically on Jenkins.
>> > >>
>> > >
>> > >+1 to wanting to see the specific test that were added, and to
>> > >understanding the testing that was done to check for any possible
>> > >regressions introduced.  We seem to have a general consensus that
>> > >master should remain stable, and the only way to do that is to talk
>> > >about tests that are done in the feature branches.
>> > >
>> > >Last, while the "Merged Expectations" document is still a draft, the
>> > >intent seems to be agreed upon (the only outstanding question is the
>> > >"how long to wait after proposing").  Can you please try to do things
>> > >in accordance with these expectations?
>> > >
>> > >https://cwiki.apache.org/confluence/display/CLOUDSTACK/Branch+Merge
>> > +Exp
>> > >ect
>> > >ations
>> > >
>> > >>
>> > >> Cheers,
>> > >>
>> > >> Hugo
>> > >>
>> > >> > -----Original Message-----
>> > >> > From: Kelven Yang [mailto:kelven.yang@citrix.com]
>> > >> > Sent: donderdag 21 februari 2013 23:39
>> > >> > To: cloudstack-dev@incubator.apache.org
>> > >> > Subject: Re: [DISCUSS]Upgrade Vmware SDK to 5.1 to support
>>Windows
>> > >> > 8 and Windows 2012 as VM guest OS on vmware
>> > >> >
>> > >> > Please merge in
>> > >> >
>> > >> > Kelven
>> > >> >
>> > >> > On 2/21/13 2:18 PM, "Min Chen" <min.chen@citrix.com> wrote:
>> > >> >
>> > >> > >Hi there,
>> > >> > >
>> > >> > >Currently Cloudstack is not supporting Windows 8 and Windows
>> > >> > >Server
>> > >> > >2012 as VM guest OS on Vmware hypervisor because we are using
>> > >> > >Vmware
>> > >> > >4.1 web service SDK in our nonoss build. In Vmware SDK 4.1,
>> > >> > >Windows 8 and Windows
>> > >> > >2012 are not supported guest OS, and they are only fully
>>supported
>> > >>for
>> > >> > >ESXi 5.1 and ESXi 5.0 Patch 4. To support Windows 8/2012 on
>>vmware
>> > >>from
>> > >> > >Cloudstack, we need to upgrade our Vmware SDK dependency from
>> > 4.1
>> > >> > >to
>> > >> > 5.1.
>> > >> > >There are several major changes that went into 5.1 SDK requiring
>> > >> > >some code changes in Cloudstack:
>> > >> > >
>> > >> > > *   Vmware SDK 5.1 is generated using JAX-WS RI implementation
>> > >>bundled
>> > >> > >with Java 6 instead of previous Axis, so api signature is
>> > >> > >completely changed. Simply replacing vim25.jar will break
>> > >> > >compilation of CloudStack code.
>> > >> > > *   Vmware SDK 5.1 for java client has gotten rid of
>>apputils.jar
>> > >>that
>> > >> > >used to be in Vmware SDK 4.1, so we need to write our own
>>wrapper
>> > >>layer
>> > >> > >to handle previous apputils methods.
>> > >> > >
>> > >> > >This feature (targeted for 4.2.0)  is to fix CloudStack code
to
>> > >> > >work with Vmware SDK 5.1 to be able to work with both Vcenter
>>5.1
>> > >> > >and
>> > >>older
>> > >> > >version of Vcenter. Vcenter back-compatibilty support of the
new
>> > >> > >5.1 SDK is guaranteed by Vmware, see
>> > >> > >http://pubs.vmware.com/vsphere-
>> > >> > 51/index.jsp?topic=%2Fcom.vmware.wssdk.dsg.
>> > >> > >doc%2Fsdk_sg_introduction.3.6.html for details.
>> > >> > >
>> > >> > >JIRA ticket:
>>https://issues.apache.org/jira/browse/CLOUDSTACK-873
>> > >> > >
>> > >> > >I have already had code working in my local feature branch
>> > >>vim51_win8,
>> > >> > >and done integration testing using Vcenter 5.1 and below,
will
>> > >> > >merge
>> > >>to
>> > >> > >master after getting approval.
>> > >> > >
>> > >> > >Thanks
>> > >> > >-min
>> > >> > >
>> > >>
>> > >>
>> 
>> 


Mime
View raw message