incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nitin Mehta <Nitin.Me...@citrix.com>
Subject Re: Review Request: CLOUDSTACK-357 ISOs can be deleted while still attached to a running VM, and they subsequently cannot be detached from a running VM
Date Fri, 15 Feb 2013 12:17:17 GMT
Great thanks Deepti.

Two things to note
#1 You might want to be careful about is that when mark the iso removed…the detach operation
should still work on the vm.
#2 Template sync might come up and delete this iso from sec. storage. You need to be careful
for ISOs in that logic.

-Nitin

From: Deepti Dohare <deepti.dohare@citrix.com<mailto:deepti.dohare@citrix.com>>
Reply-To: Deepti Dohare <deepti.dohare@citrix.com<mailto:deepti.dohare@citrix.com>>
To: "cloudstack-dev@incubator.apache.org<mailto:cloudstack-dev@incubator.apache.org>"
<cloudstack-dev@incubator.apache.org<mailto:cloudstack-dev@incubator.apache.org>>,
Nitin Mehta <nitin.mehta@citrix.com<mailto:nitin.mehta@citrix.com>>, Deepti Dohare
<deepti.dohare@citrix.com<mailto:deepti.dohare@citrix.com>>
Subject: Re: Review Request: CLOUDSTACK-357 ISOs can be deleted while still attached to a
running VM, and they subsequently cannot be detached from a running VM

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7660/


On February 15th, 2013, 8:10 a.m., Nitin Mehta wrote:

This gives the ability to the user to affect other user vms as well, which is not desirable.
I would suggest you to do the following.
When you delete iso, mark it removed in DB so that its not available for further use.
In the storage cleanup thread check whether the iso is detached for the vms and if it is then
delete it from the sec. storage.

Nitin, I agree with you and will update the patch with the suggestions you gave.


- deepti


On February 15th, 2013, 5:02 a.m., deepti dohare wrote:

Review request for cloudstack.
By deepti dohare.

Updated Feb. 15, 2013, 5:02 a.m.

Description

Currently no warning or confirmation is given or required to delete an iso which is attached
to a virtual machine.

Fixing this issue using “force” delete option.
If an admin or a user deletes an ISO which is attached to a vm:
1. Without force option; gives a warning that ISO is attached to vm “Failed to delete iso.
It is currently attached to virtual machine. Please detach it before deleting”.
2. With force option: first detach the ISO from all vms and then deletes the ISO.


Testing

Verified locally. Tested for some cases:

1. Deleting iso(not attached to any vm)
2. Deleting iso(attached to multiple vms in same domain)
3. Deleting iso(attached to multiple vms in different domains)

For admin/user


Bugs: CLOUDSTACK-357
Diffs

 *   api/src/org/apache/cloudstack/api/command/user/iso/DeleteIsoCmd.java (c821775)
 *   server/src/com/cloud/template/TemplateManagerImpl.java (f9cf277)
 *   server/src/com/cloud/vm/dao/UserVmDao.java (9fbcde3)
 *   server/src/com/cloud/vm/dao/UserVmDaoImpl.java (f2fc10b)
 *   ui/scripts/templates.js (040ce4a)

View Diff<https://reviews.apache.org/r/7660/diff/>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message