incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anthony Xu <Xuefei...@citrix.com>
Subject RE: [MERGE] Security Group in Advanced zone
Date Fri, 08 Feb 2013 20:42:17 GMT
CloudStack has plug-in framework to add different devices to CloudStack, most of the code should
be done in new java files. But they need to add a new API to add the device to CloudStack,
this new API may cross several managers, if there is no unit test for those managers, requiring
them to add unit test for those managers may scare them away.

Anthony

> -----Original Message-----
> From: David Nalley [mailto:david@gnsa.us]
> Sent: Friday, February 08, 2013 12:35 PM
> To: Anthony Xu
> Cc: Chip Childers; cloudstack-dev@incubator.apache.org
> Subject: Re: [MERGE] Security Group in Advanced zone
> 
> On Fri, Feb 8, 2013 at 3:32 PM, Anthony Xu <Xuefei.Xu@citrix.com> wrote:
> > My point is adding unit test for existing java file should be
> separate task, it should not block developers to change java file. As I
> said before, we should file a bug for each java file which doesn't have
> unit test, and arrange resources to fix these bugs.
> 
> I'll disagree.
> If it doesn't happen as changes come in, it's not going to happen.
> (unless we simply refuse to accept any changes until tests exist - but
> that's blocking developers as well)
> 
> --David

Mime
View raw message