incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Animesh Chaturvedi <animesh.chaturv...@citrix.com>
Subject RE: Review Request: Provide customizable instance names for guest VMs in cloudstack
Date Mon, 25 Feb 2013 03:17:21 GMT
Koushik

Vijay has updated the patch with your comments. Please review and commit if satisfied

Animesh

> -----Original Message-----
> From: Venkata Siva Vijayendra Bhamidipati
> [mailto:noreply@reviews.apache.org] On Behalf Of Venkata Siva Vijayendra
> Bhamidipati
> Sent: Friday, February 22, 2013 6:06 PM
> To: Frank Zhang; Kelven Yang
> Cc: Wei Zhou; Koushik Das; Vijayendra Bhamidipati; cloudstack
> Subject: Re: Review Request: Provide customizable instance names for guest
> VMs in cloudstack
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9202/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2013, 2:05 a.m.)
> 
> 
> Review request for cloudstack, Kelven Yang and Frank Zhang.
> 
> 
> Changes
> -------
> 
> Uploading a consolidated diff incorporating latest review comments, that can
> be applied on top of master.
> 
> 
> Description
> -------
> 
> Patch to allow user to append display name to internal instance name of guest
> VMs on cloudstack during guest VM creation.
> 
> 
> This addresses bug CS-778.
> 
> 
> Diffs (updated)
> -----
> 
>   server/src/com/cloud/configuration/Config.java 8c77715
>   server/src/com/cloud/vm/UserVmManagerImpl.java cf9eb27
>   server/src/com/cloud/vm/dao/VMInstanceDao.java d34b257
>   server/src/com/cloud/vm/dao/VMInstanceDaoImpl.java 531c794
>   setup/db/db/schema-410to420.sql 4637b6d
> 
> Diff: https://reviews.apache.org/r/9202/diff/
> 
> 
> Testing
> -------
> 
> Manual Testing:
> Set the global parameter vm.instancename.flag to true, restart mgmt server,
> create a guest VM and provide a display Name value when doing so. The vm
> created will have its internal name in the form of i-<>-<>-displayname.
> Set the global parameter vm.instancename.flag back to false, restart mgmt
> server, and create a guest VM providing the display Name. The vm created will
> have the internal name in the form of i-<>-<> If no display name is provided
> during instance creation, the vm internal name will be in the form of i-<>-<>.
> 
> 
> Thanks,
> 
> Venkata Siva Vijayendra Bhamidipati

Mime
View raw message