incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Animesh Chaturvedi <animesh.chaturv...@citrix.com>
Subject RE: Review Request: Added a global package name in the packaging script
Date Wed, 20 Feb 2013 23:29:10 GMT
Hugo

A gentle reminder, let's close this patch

Animesh

> -----Original Message-----
> From: Animesh Chaturvedi [mailto:animesh.chaturvedi@citrix.com]
> Sent: Friday, February 15, 2013 9:53 AM
> To: cloudstack-dev@incubator.apache.org; Wido den Hollander; Hugo Trippaers
> Cc: Pradeep Soundararajan
> Subject: RE: Review Request: Added a global package name in the packaging
> script
> 
> Hugo
> 
> Can you review and commit the patch if satisfied
> 
> > -----Original Message-----
> > From: Wido den Hollander [mailto:noreply@reviews.apache.org] On Behalf
> > Of Wido den Hollander
> > Sent: Wednesday, February 13, 2013 11:26 PM
> > To: Wido den Hollander; Hugo Trippaers
> > Cc: cloudstack; Pradeep Soundararajan
> > Subject: Re: Review Request: Added a global package name in the
> > packaging script
> >
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/9409/#review16567
> > -----------------------------------------------------------
> >
> > Ship it!
> >
> >
> > Seems fine with me, but Hugo has the most RPM knowledge, so I'll let
> > this up to him.
> >
> > From what I understand, package.sh hasn't been used that much.
> >
> > - Wido den Hollander
> >
> >
> > On Feb. 12, 2013, 12:16 p.m., Pradeep Soundararajan wrote:
> > >
> > > -----------------------------------------------------------
> > > This is an automatically generated e-mail. To reply, visit:
> > > https://reviews.apache.org/r/9409/
> > > -----------------------------------------------------------
> > >
> > > (Updated Feb. 12, 2013, 12:16 p.m.)
> > >
> > >
> > > Review request for cloudstack, Hugo Trippaers and Wido den Hollander.
> > >
> > >
> > > Description
> > > -------
> > >
> > > Added a global package name in the packaging script
> > >
> > >
> > > Diffs
> > > -----
> > >
> > >   packaging/centos63/package.sh
> > 5b1bab49b615e504273be3fe69335c10782d009a
> > >
> > > Diff: https://reviews.apache.org/r/9409/diff/
> > >
> > >
> > > Testing
> > > -------
> > >
> > >
> > > Thanks,
> > >
> > > Pradeep Soundararajan
> > >
> > >

Mime
View raw message