incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pradeep Soundararajan <pradeep.soundarara...@citrix.com>
Subject RE: Review Request: Added a global package name in the packaging script
Date Thu, 14 Feb 2013 05:07:36 GMT
Hi Animesh,

Yes, right now there are situations where we have to  change the name from cloud to cloudstack
in plenty of places after the packaging name got changed from cloud to cloudstack.

One more example is here: https://reviews.apache.org/r/9435/diff/. This java file is having
'plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java'
 hardcoded values. I think there are many like that.

If would be good if we have the package name globally added in one place (in a property file
or somewhere). We can leverage that variable in all the places including packaging scripts.

But adding the global name in the packaging script would not help. That will help only that
particular script.  We should be finding some place where we can add the package name globally.

Hugo/Wido, did you get a chance to look into this problem?

Thanks,
Pradeep S
 


-----Original Message-----
From: Animesh Chaturvedi 
Sent: Thursday, February 14, 2013 9:01 AM
To: cloudstack-dev@incubator.apache.org; Pradeep Soundararajan; Wido den Hollander; Hugo Trippaers
Subject: RE: Review Request: Added a global package name in the packaging script

Pradeep

The patch looks fine, but do we really need the change? Wido/ Hugo can you review?

> -----Original Message-----
> From: Pradeep Soundararajan [mailto:noreply@reviews.apache.org] On 
> Behalf Of Pradeep Soundararajan
> Sent: Tuesday, February 12, 2013 4:17 AM
> To: Wido den Hollander; Hugo Trippaers
> Cc: cloudstack; Pradeep Soundararajan
> Subject: Review Request: Added a global package name in the packaging 
> script
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9409/
> -----------------------------------------------------------
> 
> Review request for cloudstack, Hugo Trippaers and Wido den Hollander.
> 
> 
> Description
> -------
> 
> Added a global package name in the packaging script
> 
> 
> Diffs
> -----
> 
>   packaging/centos63/package.sh
> 5b1bab49b615e504273be3fe69335c10782d009a
> 
> Diff: https://reviews.apache.org/r/9409/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Pradeep Soundararajan

Mime
View raw message