incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Devdeep Singh <devdeep.si...@citrix.com>
Subject RE: Commits with tabs & trailing white space
Date Thu, 21 Feb 2013 05:14:04 GMT
As a contributor if a patch is submitted, applying that patch will fail if it has trailing
whitespaces. Maybe we should honor the convention of not submitting code/patches with trailing
spaces too.

Regards,
Devdeep

> -----Original Message-----
> From: Mice Xia [mailto:mice_xia@tcloudcomputing.com]
> Sent: Thursday, February 21, 2013 10:29 AM
> To: cloudstack-dev@incubator.apache.org
> Subject: RE: Commits with tabs & trailing white space
> 
> Leading spaces can be found everywhere in the codes, I think that's caused by
> IDE when intentionally leave an empty line. To me it's not a big deal and
> reviewboard provides "Hide Extra Whitespace & Hide Whitespace changes"
> to filter these. Tab should be avoided, we use 4 spaces indent by code
> convention.
> 
> -Mice
> 
> -----Original Message-----
> From: David Nalley [mailto:david@gnsa.us]
> Sent: Thursday, February 21, 2013 12:44 PM
> To: cloudstack-dev@incubator.apache.org
> Subject: Re: Commits with tabs & trailing white space
> 
> On Wed, Feb 20, 2013 at 11:37 PM, Sateesh Chodapuneedi
> <sateesh.chodapuneedi@citrix.com> wrote:
> > Seeing commits containing tab spaces and trailing white spaces.
> > Aren't we enforcing these checks?
> >
> > Regards,
> > Sateesh
> >
> 
> We desperately need more folks looking at the commit mails and calling these
> issues out. (It looks like you are doing the first, how about sending the nudge
> when you see it) Replies to commit messages will by default hit cloudstack-
> dev.
> 
> --David
Mime
View raw message