incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jayapal Reddy" <jayapalreddy.ur...@citrix.com>
Subject Re: Review Request: multiple ip address per vm nic changes for isolated and vpc networks changes.
Date Thu, 28 Feb 2013 05:24:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9396/
-----------------------------------------------------------

(Updated Feb. 28, 2013, 5:24 a.m.)


Review request for cloudstack.


Changes
-------

Removed white space chars and commented code.


Description
-------

Using this feature we can reserve secondary ip addresses for guest vm nic.
Administrator will configure the these ip addresses on the nic manually.


This addresses bug CLOUDSTACK-24.


Diffs (updated)
-----

  api/src/com/cloud/network/IpAddress.java 47df4d6 
  api/src/com/cloud/network/NetworkService.java 95bcc42 
  api/src/com/cloud/network/rules/RulesService.java 921a86e 
  api/src/com/cloud/vm/Nic.java 9d21130 
  api/src/com/cloud/vm/NicSecondaryIp.java PRE-CREATION 
  api/src/org/apache/cloudstack/api/ApiConstants.java a26b468 
  api/src/org/apache/cloudstack/api/ResponseGenerator.java 267238a 
  api/src/org/apache/cloudstack/api/command/user/firewall/CreatePortForwardingRuleCmd.java
39ab812 
  api/src/org/apache/cloudstack/api/command/user/loadbalancer/AssignToLoadBalancerRuleCmd.java
e0f9bcd 
  api/src/org/apache/cloudstack/api/command/user/nat/EnableStaticNatCmd.java ce6ea16 
  api/src/org/apache/cloudstack/api/command/user/vm/AddIpToVmNicCmd.java PRE-CREATION 
  api/src/org/apache/cloudstack/api/command/user/vm/ListNicsCmd.java PRE-CREATION 
  api/src/org/apache/cloudstack/api/command/user/vm/RemoveIpFromVmNicCmd.java PRE-CREATION

  api/src/org/apache/cloudstack/api/response/IPAddressResponse.java 251b2dd 
  api/src/org/apache/cloudstack/api/response/NicResponse.java a7d1a0d 
  api/src/org/apache/cloudstack/api/response/NicSecondaryIpResponse.java PRE-CREATION 
  api/test/org/apache/cloudstack/api/command/test/AddIpToVmNicTest.java PRE-CREATION 
  client/tomcatconf/commands.properties.in f03e8d5 
  server/src/com/cloud/api/ApiDBUtils.java ffee22f 
  server/src/com/cloud/api/ApiResponseHelper.java eafee8a 
  server/src/com/cloud/network/NetworkManager.java 2904183 
  server/src/com/cloud/network/NetworkManagerImpl.java 82893c4 
  server/src/com/cloud/network/NetworkModelImpl.java f978ac5 
  server/src/com/cloud/network/NetworkServiceImpl.java ce527b7 
  server/src/com/cloud/network/addr/PublicIp.java 7336c9c 
  server/src/com/cloud/network/dao/IPAddressDao.java 9cdb975 
  server/src/com/cloud/network/dao/IPAddressDaoImpl.java e7067d9 
  server/src/com/cloud/network/dao/IPAddressVO.java 00da5eb 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java abb4973 
  server/src/com/cloud/network/rules/RulesManagerImpl.java 614d308 
  server/src/com/cloud/network/rules/dao/PortForwardingRulesDao.java 91f08e7 
  server/src/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java 5406ab6 
  server/src/com/cloud/server/ManagementServerImpl.java e80d48c 
  server/src/com/cloud/vm/NicVO.java 8e2edda 
  server/src/com/cloud/vm/UserVmManagerImpl.java ce53c45 
  server/src/com/cloud/vm/dao/NicDao.java 762048b 
  server/src/com/cloud/vm/dao/NicDaoImpl.java 5cf152f 
  server/src/com/cloud/vm/dao/NicSecondaryIpDao.java PRE-CREATION 
  server/src/com/cloud/vm/dao/NicSecondaryIpDaoImpl.java PRE-CREATION 
  server/src/com/cloud/vm/dao/NicSecondaryIpVO.java PRE-CREATION 
  server/test/com/cloud/network/MockNetworkManagerImpl.java 3568da5 
  server/test/com/cloud/network/MockRulesManagerImpl.java ba3dd41 
  server/test/com/cloud/vpc/MockNetworkManagerImpl.java 828a555 
  setup/db/db/schema-410to420.sql 4349bd0 

Diff: https://reviews.apache.org/r/9396/diff/


Testing
-------

Tested add adding, deleting and listing addresses on the nic using APIs


Thanks,

Jayapal Reddy


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message