incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sanjay Tripathi" <sanjay.tripa...@citrix.com>
Subject Re: Review Request: CLOUDSTACK-1374: Volume table is not getting updated with volume size.
Date Mon, 25 Feb 2013 12:55:28 GMT


> On Feb. 25, 2013, 12:37 p.m., Nitin Mehta wrote:
> > server/src/com/cloud/storage/download/DownloadMonitorImpl.java, line 742
> > <https://reviews.apache.org/r/9558/diff/1/?file=261150#file261150line742>
> >
> >     What if the size is already set ? why do we need to set it again ?

This is for the final sync of volumes (same way we update the volume_host_ref table) in cases
if the volume is not completely downloaded and MS is in shutdown state(this may be one case)
etc.


- Sanjay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9558/#review17035
-----------------------------------------------------------


On Feb. 25, 2013, 12:31 p.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9558/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2013, 12:31 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Sateesh Chodapuneedi, mice xia, and Min
Chen.
> 
> 
> Description
> -------
> 
> When user uploads a volume using uploadVolume API command, only volume_host_ref table
is getting updated with corresponding size of volume and "volumes" table, the size of volume
still remains zero even ager the volume gets completely downloaded.
> 
> 
> This addresses bug CLOUDSTACK-1374.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/storage/download/DownloadListener.java d0b1868 
>   server/src/com/cloud/storage/download/DownloadMonitorImpl.java e12bc32 
> 
> Diff: https://reviews.apache.org/r/9558/diff/
> 
> 
> Testing
> -------
> 
> Verified the fix on my local CloudStack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message