incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "deepti dohare" <deepti.doh...@citrix.com>
Subject Re: Review Request: CLOUDSTACK-357 ISOs can be deleted while still attached to a running VM, and they subsequently cannot be detached from a running VM
Date Mon, 25 Feb 2013 08:55:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7660/
-----------------------------------------------------------

(Updated Feb. 25, 2013, 8:55 a.m.)


Review request for cloudstack and Min Chen.


Changes
-------

Resolved Conflicts. 


Description
-------

Currently no warning or confirmation is given or required to delete an iso which is attached
to a virtual machine.

Fixing this issue using “force” delete option.
If an admin or a user deletes an ISO which is attached to a vm:
1. Without force option; gives a warning that ISO is attached to vm “Failed to delete iso.
It is currently attached to virtual machine. Please detach it before deleting”.
2. With force option: first detach the ISO from all vms and then deletes the ISO. 


This addresses bug CLOUDSTACK-357.


Diffs (updated)
-----

  server/src/com/cloud/storage/dao/VMTemplateHostDaoImpl.java 4d19bfc 
  server/src/com/cloud/storage/download/DownloadMonitorImpl.java e12bc32 
  server/src/com/cloud/template/HyervisorTemplateAdapter.java c1177f4 
  server/src/com/cloud/template/TemplateAdapterBase.java 247ce63 
  server/src/com/cloud/template/TemplateManagerImpl.java 101c3d9 
  server/src/com/cloud/vm/dao/UserVmDao.java 9fbcde3 
  server/src/com/cloud/vm/dao/UserVmDaoImpl.java f2fc10b 

Diff: https://reviews.apache.org/r/7660/diff/


Testing
-------

Verified locally. Tested for some cases:

1. Deleting iso(not attached to any vm)
2. Deleting iso(attached to multiple vms in same domain)
3. Deleting iso(attached to multiple vms in different domains)

For admin/user


Thanks,

deepti dohare


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message