incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sanjay Tripathi" <sanjay.tripa...@citrix.com>
Subject Re: Review Request: CLOUDSTACK-1156: Limit Primary and Secondary storage for domain/accounts
Date Thu, 21 Feb 2013 17:03:25 GMT


> On Feb. 21, 2013, 2:15 p.m., Sateesh Chodapuneedi wrote:
> > server/src/com/cloud/api/query/dao/AccountJoinDaoImpl.java, line 180
> > <https://reviews.apache.org/r/9541/diff/1/?file=260599#file260599line180>
> >
> >     Need to see if the division result might cause skew in calculations involving
these variables.

This conversion (bytes to GiB) is just for display the limits in response and not for any
calculation. 


> On Feb. 21, 2013, 2:15 p.m., Sateesh Chodapuneedi wrote:
> > server/src/com/cloud/vm/UserVmManagerImpl.java, line 2416
> > <https://reviews.apache.org/r/9541/diff/1/?file=260615#file260615line2416>
> >
> >     how about snapshot value null here?

This method is called by createTemplate API and in this API, one of the parameter is required
i.e volume or snapshot. Both cannot be null at same time.


On Feb. 21, 2013, 2:15 p.m., Sanjay Tripathi wrote:
> > Would like to know if there are upgrade scenarios considered.

Upgrade scenarios are already considered.
you can look in to the FS to know about upgrade scenarios. 
FS: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Limit+Resources+to+domains+and+accounts


- Sanjay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9541/#review16846
-----------------------------------------------------------


On Feb. 21, 2013, 4:51 p.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9541/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2013, 4:51 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Min Chen.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-1156: Limit Primary and Secondary storage for domain/accounts
>     
>     Addition of two new resource types i.e. Primary and Secondary storage space in the
existing pool of
>     resource types.
>     Added methods to set the limits on these resources using updateResourceLimit
>     API command and to get a count using updateResourceCount. Also added calls in the
>     Templates, Volumes, Snapshots life cycle to check these limits and to increment/decrement
the new
>     resource types
>     
>     Resource Name          :: Resource type number
>         Primary Storage               10
>         Secondary Storage             11
>     
>     Also added jUnit Tests for the same.
> 
> 
> This addresses bug CLOUDSTACK-1156.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/configuration/Resource.java 7614c8a 
>   api/src/org/apache/cloudstack/api/command/user/resource/UpdateResourceCountCmd.java
f6d3a98 
>   api/src/org/apache/cloudstack/api/command/user/resource/UpdateResourceLimitCmd.java
0039f62 
>   api/src/org/apache/cloudstack/api/response/AccountResponse.java 9a98a35 
>   api/src/org/apache/cloudstack/api/response/ResourceCountResponse.java a7fbbf2 
>   api/src/org/apache/cloudstack/api/response/ResourceLimitResponse.java b444e7a 
>   server/src/com/cloud/api/ApiResponseHelper.java a94e935 
>   server/src/com/cloud/api/query/dao/AccountJoinDaoImpl.java 898bafc 
>   server/src/com/cloud/api/query/vo/AccountJoinVO.java cd7231c 
>   server/src/com/cloud/baremetal/BareMetalTemplateAdapter.java 4440b7a 
>   server/src/com/cloud/baremetal/BareMetalVmManagerImpl.java 5de5ccd 
>   server/src/com/cloud/configuration/Config.java c0c23b6 
>   server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java 7ff06af 
>   server/src/com/cloud/storage/StorageManagerImpl.java 05e0cfe 
>   server/src/com/cloud/storage/dao/SnapshotDao.java 3b961f6 
>   server/src/com/cloud/storage/dao/SnapshotDaoImpl.java a8a07dc 
>   server/src/com/cloud/storage/dao/VolumeDao.java d7a2667 
>   server/src/com/cloud/storage/dao/VolumeDaoImpl.java a189d00 
>   server/src/com/cloud/storage/download/DownloadMonitorImpl.java 6d3cf2a 
>   server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java e06da75 
>   server/src/com/cloud/template/HyervisorTemplateAdapter.java fe6bc2a 
>   server/src/com/cloud/template/TemplateAdapterBase.java fa677ac 
>   server/src/com/cloud/template/TemplateManagerImpl.java f9cf277 
>   server/src/com/cloud/vm/UserVmManagerImpl.java ed8cd36 
>   server/test/com/cloud/resourcelimit/ResourceLimitManagerImplTest.java d311ad3 
>   server/test/com/cloud/vpc/MockResourceLimitManagerImpl.java b9fc861 
>   setup/db/db/schema-40to410.sql 47b7cbe 
>   setup/db/db/schema-410to420.sql 0335f2a 
>   utils/src/com/cloud/utils/UriUtils.java a8b5ccb 
> 
> Diff: https://reviews.apache.org/r/9541/diff/
> 
> 
> Testing
> -------
> 
> Tested life cycle of templates, volumes, snapshots, vm on my local CloudStack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message