incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sateesh Chodapuneedi" <sateesh.chodapune...@citrix.com>
Subject Re: Review Request: (CLOUDSTACK-1325) add password in response of RestoreVM
Date Thu, 21 Feb 2013 11:40:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9539/#review16841
-----------------------------------------------------------



server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/9539/#comment35763>

    Need to fix tab spaces here



server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/9539/#comment35765>

    There is good amount of common code in this snippet and resetPassword method in UserVmManagerImpl.
Can you see if it is something to move into separate function.



server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/9539/#comment35762>

    Need to fix tab spaces here



server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/9539/#comment35764>

    Need to fix trailing white spaces here


- Sateesh Chodapuneedi


On Feb. 21, 2013, 11:29 a.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9539/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2013, 11:29 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> In 4.0.1, There is no password field in the respone of RestoreVM.
> Please see https://issues.apache.org/jira/browse/CLOUDSTACK-1325
> 
> This patch add a new password in the response.
> 
> 
> This addresses bug CLOUDSTACK-1325.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/vm/UserVmService.java 6635657 
>   server/src/com/cloud/vm/UserVmManagerImpl.java dbcbeb8 
> 
> Diff: https://reviews.apache.org/r/9539/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> 
> command=restoreVirtualMachine&response=json&virtualmachineid=1a53a308-c870-452a-9eff-23975919286b
>  public $jobid =>
>  string(36) "7e855ed2-b5ab-4449-a163-5c1af62019ab"
> 
> command=queryAsyncJobResult&response=json&jobid=7e855ed2-b5ab-4449-a163-5c1af62019ab
>  public $password =>
>  string(9) "mD5qkzmdk"
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message