incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harikrishna Patnala" <harikrishna.patn...@citrix.com>
Subject Re: Review Request: CLOUDSTACK-667: VM's base image updation facility
Date Fri, 15 Feb 2013 08:53:38 GMT


> On Feb. 15, 2013, 8:44 a.m., Koushik Das wrote:
> > server/src/com/cloud/vm/UserVmManagerImpl.java, line 4799
> > <https://reviews.apache.org/r/9158/diff/4/?file=256587#file256587line4799>
> >
> >     What if template is null? The null check that's happening in the 'else' case
should be made for both existing as well as new template

As the newtemplate UUID is passed as parameter, this is taken care in the UUID to ID conversion
while finding the objectVO and checking for its internal Id.


- Harikrishna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9158/#review16635
-----------------------------------------------------------


On Feb. 7, 2013, 11:32 a.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9158/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2013, 11:32 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Koushik Das.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-667: VM's base image updation facility
> disconnect the root disk >> destroy root disk >> create a new disk from new
template >> attach new disk as root disk to the vm 
> 
> 
> This addresses bug CLOUDSTACK-667.
> 
> 
> Diffs
> -----
> 
>   api/src/org/apache/cloudstack/api/command/user/vm/RestoreVMCmd.java e98c2f2 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 390a2a2 
>   server/test/com/cloud/vm/UserVmManagerTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/9158/diff/
> 
> 
> Testing
> -------
> 
> Did the manual testing locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message