incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chiradeep Vittal" <chirade...@gmail.com>
Subject Re: Review Request: Support for VHDX image format, and update to RegisterTemplate UI to support Hyper-V 2012
Date Thu, 14 Feb 2013 19:21:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9444/#review16599
-----------------------------------------------------------


I feel this should part of a patch set. On its own the patch doesn't make sense: users will
see a way to register a VHDX template but with no way to use it.
Can you submit it with the rest of the Hyper-v features ?

- Chiradeep Vittal


On Feb. 14, 2013, 1:52 p.m., Donal Lafferty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9444/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2013, 1:52 p.m.)
> 
> 
> Review request for cloudstack and Animesh Chaturvedi.
> 
> 
> Description
> -------
> 
> Add support for VHDX image type, and allow UI for RegisterTemplate to support both Hyper-V
image types.
> 
> 
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1032.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/storage/Storage.java fba12b6 
>   server/src/com/cloud/storage/StorageManagerImpl.java 05e0cfe 
>   server/src/com/cloud/template/HyervisorTemplateAdapter.java 089f650 
>   ui/scripts/templates.js 040ce4a 
> 
> Diff: https://reviews.apache.org/r/9444/diff/
> 
> 
> Testing
> -------
> 
> Integration test on code when built for Hyper-V Phase 1 fork.
> 
> Not clear what unit tests can be updated to walk the code.
> 
> 
> Thanks,
> 
> Donal Lafferty
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message