incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasanna Santhanam" <Prasanna.Santha...@citrix.com>
Subject Re: Review Request: (CLOUDSTACK-1088) EnableStaticNat error will clear the data in database
Date Wed, 13 Feb 2013 13:17:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9254/#review16513
-----------------------------------------------------------

Ship it!


commit 2e2ee2f3ed389b1b1a8a89eae8a641314417ca83
Author: Wei Zhou <w.zhou@leaseweb.com>
Date:   Wed Feb 13 18:42:38 2013 +0530

    CLOUDSTACK-1088: EnableStaticNat error will clear the data in database
    
    The issue occur in two conditions
    
    (1) If I use two sessions or browsers to EnableStaticNat on CloudStack
    UI. one is successful, the other is failed. However, there is no ip in
    database.
    
    (2) If I use API call EnableStaticNat several times The first time
    succeed, the second failed, the third succeed. the result is
    success-fail-success-fail-success-fail, which it is not correct.
    
    Reported-by: Wei Zhou <w.zhou@leaseweb.com>
    Reviewed-by: https://reviews.apache.org/r/9254/
    Signed-off-by: Prasanna Santhanam <tsp@apache.org>


Applied on master (2e2ee2), 4.1 (f81719e), and 4.0 (a61a2b)

- Prasanna Santhanam


On Feb. 11, 2013, 10:10 a.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9254/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2013, 10:10 a.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam, Jessica Wang, and Chiradeep Vittal.
> 
> 
> Description
> -------
> 
> The issue occur in two conditions
> (1) If I use two sessions or browsers to EnableStaticNat on CloudStack UI. one is successful,
the other is failed. However, there is no ip in database.
> (2) If I use API call EnableStaticNat several times The first time succeed, the second
failed, the third succeed. the result is success-fail-success-fail-success-fail, which it
is not correct.
> 
> This is because the improperly use of result boolean flag in com.cloud.network.rules.RulesManagerImpl.enableStaticNat(long,
long, long, boolean), the table user_ip_address(one_to_one_nat , vm_id) will set to (0,null)
when the operation failed.
> 
> For this issue, I add a new flag "updated" to describe whether the table user_ip_address
in database has been changed..
> 
> 
> This addresses bug CLOUDSTACK-1088.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/network/rules/RulesManagerImpl.java 0a00d22 
> 
> Diff: https://reviews.apache.org/r/9254/diff/
> 
> 
> Testing
> -------
> 
> Test in following operations
> (1) assign a ip to a vm several times.
> (2) assign two ip to a vm
> (3) assign a ip to two vms
> It works well.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message