incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ilya musayev" <i...@cloudsand.com>
Subject Re: Review Request: PATCH-4 for feature VMware vNetwork Distributed Virtual Switch support in CloudStack
Date Mon, 11 Feb 2013 21:08:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9201/#review16442
-----------------------------------------------------------



vmware-base/test/com/cloud/vmware/TestVMWare.java
<https://reviews.apache.org/r/9201/#comment34926>

    why hardcoded IP?



vmware-base/test/com/cloud/vmware/TestVMWare.java
<https://reviews.apache.org/r/9201/#comment34927>

    hardcoded ip?



vmware-base/test/com/cloud/vmware/TestVMWare.java
<https://reviews.apache.org/r/9201/#comment34928>

    dvs-921 is set static?



vmware-base/test/com/cloud/vmware/TestVMWare.java
<https://reviews.apache.org/r/9201/#comment34929>

    please revise section below.


- ilya musayev


On Feb. 5, 2013, 5:43 a.m., Sateesh Chodapuneedi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9201/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2013, 5:43 a.m.)
> 
> 
> Review request for cloudstack, Murali Reddy and Kelven Yang.
> 
> 
> Description
> -------
> 
> This is 4th patch for feature 'Support for VMware dvSwitch in CloudStack'.
> This patch contains, test cases and changes to prepareNetwork function to consider vmware
dvswitch as well. Trying to create new dv port group if not alreayd present and update in
case of modification of dvportgroup shaping policy.
> 
> 
> This addresses bug CLOUDSTACK-657.
> 
> 
> Diffs
> -----
> 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 50f9541 
>   vmware-base/test/com/cloud/vmware/TestVMWare.java 43c784c 
> 
> Diff: https://reviews.apache.org/r/9201/diff/
> 
> 
> Testing
> -------
> 
> Manual testing:-
> 1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management
and public traffic uses standard vSwitch on a common physical network.
> 2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
> 3) Use optional parameters added to AddClusterCmd to override Zone level network traffic
label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
> 4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch'
set to false. This is default configuration scenario.
> 
> 
> Added following tests,
> 1) Test fetching dvSwitch object from vCenter
> 2) Test for presence of dvPortGroup
> 3) Test presence of dvPortGroup
> 4) Test get existing dvPortGroup
> 5) fetch dvPortGroup configuration
> 6) Test compare dvPortGroup configuration
> 7) Test update dvPortGroup configuration
> 
> 
> Thanks,
> 
> Sateesh Chodapuneedi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message