incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prachi Damle" <prachi.da...@citrix.com>
Subject Re: Review Request: [EC2 Query API] RunInstances, instance is always deployed in the default security group
Date Mon, 11 Feb 2013 19:21:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9225/#review16437
-----------------------------------------------------------

Ship it!


Fixes are ok to set the specified security group. Commit hash:	f839ad7b53ff805712852da0dd564b9857236c33





- Prachi Damle


On Feb. 1, 2013, 5:48 a.m., Likitha Shetty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9225/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2013, 5:48 a.m.)
> 
> 
> Review request for cloudstack and Prachi Damle.
> 
> 
> Description
> -------
> 
> During EC2RunInstances, even if the security group the instance is to be deployed in
specified the instance gets deployed in the default security group
> 
> 
> This addresses bug CLOUDSTACK-1121.
> 
> 
> Diffs
> -----
> 
>   awsapi/src/com/cloud/bridge/service/EC2RestServlet.java 78e736f 
>   awsapi/src/com/cloud/bridge/service/EC2SoapServiceImpl.java b2451c6 
>   awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java 17752af 
>   awsapi/src/com/cloud/bridge/service/core/ec2/EC2Instance.java 9b43cb7 
>   awsapi/src/com/cloud/bridge/service/core/ec2/EC2InstanceFilterSet.java 449d89e 
> 
> Diff: https://reviews.apache.org/r/9225/diff/
> 
> 
> Testing
> -------
> 
> 1. Create a security grouo 'sg1' 
> 2. Run ec2_run_instances with parameter 'sg1'  - Check CS to confirm instance got deployed
in 'sg1' 
> 
> 
> Thanks,
> 
> Likitha Shetty
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message