incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hongtu Zang" <hongtu_z...@tcloudcomputing.com>
Subject Re: Review Request: CLOUDSTACK-644 add vmware resizeVolume support
Date Wed, 06 Feb 2013 09:02:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9241/
-----------------------------------------------------------

(Updated Feb. 6, 2013, 9:02 a.m.)


Review request for cloudstack, mice xia and Marcus Sorensen.


Changes
-------

rebased and you can apply it cleanly.


Description
-------

add vmware resizeVolume support


This addresses bug CLOUDSTACK-644.


Diffs (updated)
-----

  plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
a1b1336 
  server/src/com/cloud/storage/StorageManagerImpl.java 45e3a7f 

Diff: https://reviews.apache.org/r/9241/diff/


Testing
-------

Start a vm using builtin template [CentOS 5.3(64-bit) no GUI (vSphere)].
Attach two data volumes, one made by disk_offering "Small", another made by "Custom".
Try to resize the two volumes when vm in running or stopped state.
After the api finished resize the volume, we found the size changed in the vSphere Client
while the size in system is not changed. Reboot the vm and use fdisk to check the disk size,
we found the size is changed.

If we try to shrink the volume, the vsphere will throw an exception, I add a check in the
code before resize volume. If the newSize is smaller, it will return false.


Thanks,

Hongtu Zang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message