incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcus Sorensen" <shadow...@gmail.com>
Subject Re: Review Request: CLOUDSTACK-644 add vmware resizeVolume support
Date Wed, 06 Feb 2013 05:14:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9241/#review16165
-----------------------------------------------------------


Thanks, all problems resolved. It doesn't apply cleanly, however. Could you rebase it and
I'll get it committed?

- Marcus Sorensen


On Feb. 6, 2013, 1:57 a.m., Hongtu Zang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9241/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2013, 1:57 a.m.)
> 
> 
> Review request for cloudstack, mice xia and Marcus Sorensen.
> 
> 
> Description
> -------
> 
> add vmware resizeVolume support
> 
> 
> This addresses bug CLOUDSTACK-644.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
dd917f7 
>   server/src/com/cloud/storage/StorageManagerImpl.java 07f4d8a 
> 
> Diff: https://reviews.apache.org/r/9241/diff/
> 
> 
> Testing
> -------
> 
> Start a vm using builtin template [CentOS 5.3(64-bit) no GUI (vSphere)].
> Attach two data volumes, one made by disk_offering "Small", another made by "Custom".
> Try to resize the two volumes when vm in running or stopped state.
> After the api finished resize the volume, we found the size changed in the vSphere Client
while the size in system is not changed. Reboot the vm and use fdisk to check the disk size,
we found the size is changed.
> 
> If we try to shrink the volume, the vsphere will throw an exception, I add a check in
the code before resize volume. If the newSize is smaller, it will return false.
> 
> 
> Thanks,
> 
> Hongtu Zang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message