incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Koushik Das" <koushik....@citrix.com>
Subject Re: Review Request: Patch 2 : CLOUDSTACK-657 VMware vNetwork Distributed Virtual Switch support in CloudStack
Date Tue, 05 Feb 2013 08:05:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9191/#review16093
-----------------------------------------------------------



api/src/org/apache/cloudstack/api/ApiConstants.java
<https://reviews.apache.org/r/9191/#comment34419>

    Why there are 2 ApiConstants.java? Which one is correct



api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java
<https://reviews.apache.org/r/9191/#comment34422>

    Why only switch type and not name? Also where do they get stored?



server/src/com/cloud/configuration/Config.java
<https://reviews.apache.org/r/9191/#comment34424>

    What is the upgrade logic? Since these are removed where do they get mapped to after upgrade?



server/src/com/cloud/configuration/Config.java
<https://reviews.apache.org/r/9191/#comment34426>

    In the description you have mentioned that both nexus and vmware dvswitch is enabled/disabled.
What happens to the existing parameter vmware.use.nexus.vswitch?
    
    Also if vmware.use.nexus.vswitch is enabled during cluster add VSM details are required,
now what parameter governs that?


- Koushik Das


On Feb. 5, 2013, 5:28 a.m., Sateesh Chodapuneedi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9191/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2013, 5:28 a.m.)
> 
> 
> Review request for cloudstack, Murali Reddy and Kelven Yang.
> 
> 
> Description
> -------
> 
> This is 2nd patch for feature 'Support for VMware dvSwitch in CloudStack'.
> 
> This patch introduces 2 new global configuration parameters 
> "vmware.use.dvswitch" - Enable dvswitch functionality.
> "vmware.ports.per.dvportgroup" - Default number of ports per Vmware dvPortGroup.
> 
> 
> This addresses bug CLOUDSTACK-657.
> 
> 
> Diffs
> -----
> 
>   api/src/org/apache/cloudstack/api/ApiConstants.java d084271 
>   api/src/org/apache/cloudstack/api/ApiConstants.java 58a7831 
>   api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java c64883c

>   server/src/com/cloud/configuration/Config.java 4ae144e 
> 
> Diff: https://reviews.apache.org/r/9191/diff/
> 
> 
> Testing
> -------
> 
> Manual testing:-
> 1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management
and public traffic uses standard vSwitch on a common physical network.
> 2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
> 3) Use optional parameters added to AddClusterCmd to override Zone level network traffic
label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
> 4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch'
set to false. This is default configuration scenario.
> 
> 
> Added following tests,
> 1) Test fetching dvSwitch object from vCenter
> 2) Test for presence of dvPortGroup
> 3) Test presence of dvPortGroup
> 4) Test get existing dvPortGroup
> 5) fetch dvPortGroup configuration
> 6) Test compare dvPortGroup configuration
> 7) Test update dvPortGroup configuration
> 
> 
> Thanks,
> 
> Sateesh Chodapuneedi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message