incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murali Reddy" <muralimmre...@gmail.com>
Subject Re: Review Request: IP Address Reservation within a Network
Date Fri, 01 Feb 2013 11:06:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9180/#review16003
-----------------------------------------------------------



api/src/com/cloud/network/Network.java
<https://reviews.apache.org/r/9180/#comment34304>

    can you rename getter names to reflect what they are returning
    
    getNeworkCidr getGuestVmCidr



api/src/org/apache/cloudstack/api/response/NetworkResponse.java
<https://reviews.apache.org/r/9180/#comment34305>

    keep both request and response has same cidr.
    
    i.e specify only guestVmCidr,



server/src/com/cloud/api/ApiResponseHelper.java
<https://reviews.apache.org/r/9180/#comment34306>

    return what is reserved for guest VM, let the caller figure what is reserved for non cloudstack
VM's



setup/db/create-schema.sql
<https://reviews.apache.org/r/9180/#comment34303>

    can you rename to reflect the purpose of CIDR and give better description message defining
the fields
    
    e.g., network_cidr, guest_vm_cidr



setup/db/db/schema-40to410.sql
<https://reviews.apache.org/r/9180/#comment34307>

    do you expect the guest_cidr's to be null after upgrade or same as cidr?


- Murali Reddy


On Feb. 1, 2013, 10:34 a.m., saksham srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9180/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2013, 10:34 a.m.)
> 
> 
> Review request for cloudstack, Murali Reddy and Chiradeep Vittal.
> 
> 
> Description
> -------
> 
>     CLOUDSTACK-705 IP Address reservation for Isolated Guest Networks
> 
> 
> CloudStack uses Guest CIDR for dhcp-range for the Guest VMs. The entire CIDR is used
by CloudStack for assigning IPs to Guest VMs.
> IP Address Reservation will allow part of address space to be used for non CloudStack
hosts/physical servers also, by restricting the address space of CloudStack Guest VMs.
> Reservation can be configured using update Network API by specifying guestvmCidr as an
additional parameter.
> Reservation will be applicable for Isolated Guest Networks including VPC.
> reservediprange in the response will return the IP range that can be used for non Cloudstack
hosts.
> 
> 
> This addresses bug CLOUDSTACK-705.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/network/Network.java a70bf02 
>   api/src/com/cloud/network/NetworkProfile.java e3be941 
>   api/src/com/cloud/network/NetworkService.java 786afb1 
>   api/src/com/cloud/network/vpc/VpcService.java 68e062c 
>   api/src/org/apache/cloudstack/api/ApiConstants.java d895191 
>   api/src/org/apache/cloudstack/api/command/user/network/UpdateNetworkCmd.java 978c71b

>   api/src/org/apache/cloudstack/api/response/NetworkResponse.java 40d6850 
>   server/src/com/cloud/api/ApiResponseHelper.java 2dcd09c 
>   server/src/com/cloud/network/NetworkServiceImpl.java 5c70caa 
>   server/src/com/cloud/network/NetworkVO.java 8020e7a 
>   server/src/com/cloud/network/vpc/VpcManagerImpl.java 26e882e 
>   server/test/com/cloud/network/MockNetworkManagerImpl.java af0b03f 
>   server/test/com/cloud/vpc/MockNetworkManagerImpl.java 382068a 
>   server/test/com/cloud/vpc/MockVpcManagerImpl.java 25799d1 
>   setup/db/create-schema.sql a847b43 
>   setup/db/db/schema-40to410.sql 6d5b262 
> 
> Diff: https://reviews.apache.org/r/9180/diff/
> 
> 
> Testing
> -------
> 
> Tested manually the following scenarios:
> Applying reservation when there are running VMs inside the guest_vm_cidr.
> Applying reservation when there are running VMs outside the guest_vm_cidr.(not allowed)
> Applying reservation when external device like Netscaler is configured in the guest_cidr.
> Applying reservation in VPC tiers.
> Applying reservation outside the range of guest_cidr.(not allowed)
> 
> 
> Thanks,
> 
> saksham srivastava
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message