incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sanjay Tripathi" <sanjay.tripa...@citrix.com>
Subject Re: Review Request: CLOUDSTACK-713 Limit Resources to domain/accounts
Date Fri, 01 Feb 2013 10:28:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9110/
-----------------------------------------------------------

(Updated Feb. 1, 2013, 10:28 a.m.)


Review request for cloudstack, Devdeep Singh, Nitin Mehta, Prasanna Santhanam, Chiradeep Vittal,
and Min Chen.


Changes
-------

Resolved the conflicts and changed the @since tag for new arguments to 4.1.0


Description
-------

CLOUDSTACK-713: Limit Resources to domain/accounts (CPU and Memory)
    
    Addition of two new resource types i.e. CPU and RAM in the existing pool of
    resource types.
    Added some methods to set the limits on these resources using updateResource
    API command and to get a count using updateResourceCount. Also added calls in
    Virtual machine life cycle to check these limits and to increment/decrement 
    resource count
    
    Resource Name  :: Resource type number
        CPU               8
        Memory            9


This addresses bug CLOUDSTACK-713.


Diffs (updated)
-----

  api/src/com/cloud/configuration/Resource.java 7f551d6 
  api/src/org/apache/cloudstack/api/command/user/resource/UpdateResourceCountCmd.java 4aa694b

  api/src/org/apache/cloudstack/api/command/user/resource/UpdateResourceLimitCmd.java 9b6359f

  api/src/org/apache/cloudstack/api/response/AccountResponse.java 51d3352 
  api/src/org/apache/cloudstack/api/response/ResourceCountResponse.java 7a29194 
  api/src/org/apache/cloudstack/api/response/ResourceLimitResponse.java c01e12f 
  server/src/com/cloud/api/query/dao/AccountJoinDaoImpl.java 6268724 
  server/src/com/cloud/api/query/vo/AccountJoinVO.java 6d37f4d 
  server/src/com/cloud/baremetal/BareMetalVmManagerImpl.java 6ff37ea 
  server/src/com/cloud/configuration/Config.java 5e4996b 
  server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java c17b0ea 
  server/src/com/cloud/vm/UserVmManagerImpl.java a53e132 
  server/test/com/cloud/resourcelimit/ResourceLimitManagerImplTest.java PRE-CREATION 
  server/test/com/cloud/vpc/MockResourceLimitManagerImpl.java a0c7b70 
  setup/db/create-schema-view.sql f68a6ca 
  setup/db/db/schema-40to410.sql 39b686e 

Diff: https://reviews.apache.org/r/9110/diff/


Testing
-------

Manually tested on my local CloudStack setup.
Tested deployVirtualMachine API command with/without exceeded limits.
Also tested APIs like: assignVirtualMachine, recoverVirtualMachine, destroyVirtualMachine
commands and checked the corresponding increment/decrement in the resource count in database.
Added unit tests in the patch.


Thanks,

Sanjay Tripathi


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message