incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sateesh Chodapuneedi" <sateesh.chodapune...@citrix.com>
Subject Re: Review Request: CLOUDSTACK-644 add vmware resizeVolume support
Date Fri, 01 Feb 2013 09:41:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9241/#review15998
-----------------------------------------------------------



plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
<https://reviews.apache.org/r/9241/#comment34298>

    Need to cleanup tabs and extraneous white spaces.



plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
<https://reviews.apache.org/r/9241/#comment34300>

    Better to do is null check for disk object 



plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
<https://reviews.apache.org/r/9241/#comment34301>

    Are we checking for newSize equal to oldSize before arriving at this code? If not we can
do the check here and return ResizeVolumeAnswer(cmd, true, "success")



plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
<https://reviews.apache.org/r/9241/#comment34299>

    Because we got an exception better log level of this message be 'error'



server/src/com/cloud/storage/StorageManagerImpl.java
<https://reviews.apache.org/r/9241/#comment34297>

    Need to update the comment here as support is being added to VMware as well.


- Sateesh Chodapuneedi


On Feb. 1, 2013, 9:23 a.m., Hongtu Zang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9241/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2013, 9:23 a.m.)
> 
> 
> Review request for cloudstack, mice xia and Marcus Sorensen.
> 
> 
> Description
> -------
> 
> add vmware resizeVolume support
> 
> 
> This addresses bug CLOUDSTACK-644.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
dd917f7 
>   server/src/com/cloud/storage/StorageManagerImpl.java 07f4d8a 
> 
> Diff: https://reviews.apache.org/r/9241/diff/
> 
> 
> Testing
> -------
> 
> Start a vm using builtin template [CentOS 5.3(64-bit) no GUI (vSphere)].
> Attach two data volumes, one made by disk_offering "Small", another made by "Custom".
> Try to resize the two volumes when vm in running or stopped state.
> After the api finished resize the volume, we found the size changed in the vSphere Client
while the size in system is not changed. Reboot the vm and use fdisk to check the disk size,
we found the size is changed.
> 
> If we try to shrink the volume, the vsphere will throw an exception, I add a check in
the code before resize volume. If the newSize is smaller, it will return false.
> 
> 
> Thanks,
> 
> Hongtu Zang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message