incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Brockmeier <...@zonker.net>
Subject Re: Branch Merge Expectations - Draft for Discussion
Date Thu, 21 Feb 2013 16:40:45 GMT
On Wed, Feb 20, 2013, at 04:23 PM, Animesh Chaturvedi wrote:
> Do we really need to wait 72 hours for all merge requests? I feel that
> slows developers down unless they plan very well. 

What's wrong with the expectation being that they plan very well? ;-)

Remember, "community over code." The point of waiting 72 hours is to
give the community the opportunity to review, comment, etc. 

The point that some merges are less disruptive / intrusive than others
is well-taken, though. Perhaps that is something that could be discussed
during the feature proposal and decided then. If the community decides
up-front that a merge is unlikely to be a problem, then maybe the
expectation would be that only 48 or 24 hours needs to pass to allow for
review & comments. But it should be explicit, and I'd rather err on the
side of allowing the community time to review.

Best,

jzb
-- 
Joe Brockmeier
jzb@zonker.net
Twitter: @jzb
http://www.dissociatedpress.net/

Mime
View raw message