Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Date: Thu, 24 Jan 2013 12:53:12 +0000 (UTC)
From: "Noa Resare (JIRA)" <jira@apache.org>
To: cloudstack-dev@incubator.apache.org
Message-ID: <JIRA.12629063.1359031914059.184657.1359031992798@arcas>
In-Reply-To: <JIRA.12629063.1359031914059@arcas>
References: <JIRA.12629063.1359031914059@arcas>
Subject: [jira] [Created] (CLOUDSTACK-1052) security_group.py broken
 add_network_rules() exception handling hides all errors
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Noa Resare created CLOUDSTACK-1052:
--------------------------------------

             Summary: security_group.py broken add_network_rules() exception handling hides all errors
                 Key: CLOUDSTACK-1052
                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-1052
             Project: CloudStack
          Issue Type: Bug
      Security Level: Public (Anyone can view this level - this is the default.)
            Reporter: Noa Resare
            Priority: Minor


Line 695 in version 6f29317 of security_group.py hides all possible errors in the add_network_rules() function due to a unfortunate attempt to concatenate a str with type.

In principle one could have lots of objections to that code. Why only log on debug level debug, when there was an unexpected error? The english in the error message doesn't really parse. 

Personally I would prefer removing it altogether. If we want to log all exceptions via the logging framework instead of leaving that responsibility to the caller a generic catch all in the last block of the file that logs everything that no one else catches properly would be a better option.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira