Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 523A7E4E9 for ; Wed, 30 Jan 2013 08:05:05 +0000 (UTC) Received: (qmail 2778 invoked by uid 500); 30 Jan 2013 08:05:04 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 2617 invoked by uid 500); 30 Jan 2013 08:05:04 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 2604 invoked by uid 99); 30 Jan 2013 08:05:03 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Jan 2013 08:05:03 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6E9481C6EE2; Wed, 30 Jan 2013 08:04:57 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8908013400185379598==" MIME-Version: 1.0 Subject: Re: Review Request: CLOUDSTACK-299 Egress firewall rules feature for guest network on VR From: "Abhinandan Prateek" To: "Animesh Chaturvedi" , "Abhinandan Prateek" Cc: "cloudstack" , "Jayapal Reddy" Date: Wed, 30 Jan 2013 08:04:57 -0000 Message-ID: <20130130080457.24984.10205@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Abhinandan Prateek" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/9010/ X-Sender: "Abhinandan Prateek" References: <20130130080419.24967.48358@reviews.apache.org> In-Reply-To: <20130130080419.24967.48358@reviews.apache.org> Reply-To: "Abhinandan Prateek" --===============8908013400185379598== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Jan. 30, 2013, 8:04 a.m., Abhinandan Prateek wrote: > > Ship It! Unit tests are missing. - Abhinandan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9010/#review15829 ----------------------------------------------------------- On Jan. 17, 2013, 3:35 p.m., Jayapal Reddy wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9010/ > ----------------------------------------------------------- > = > (Updated Jan. 17, 2013, 3:35 p.m.) > = > = > Review request for cloudstack, Abhinandan Prateek and Animesh Chaturvedi. > = > = > Description > ------- > = > Egress firewall rules feature for the guest networks. > The current changes includes for the VR only. > = > = > This addresses bug CLOUDSTACK-299. > = > = > Diffs > ----- > = > api/src/com/cloud/agent/api/to/FirewallRuleTO.java 95ac57c = > api/src/com/cloud/network/Network.java c91f6a9 = > api/src/com/cloud/network/NetworkProfile.java b5c463d = > api/src/com/cloud/network/firewall/FirewallService.java 3858499 = > api/src/org/apache/cloudstack/api/command/user/firewall/CreateEgressFir= ewallRuleCmd.java PRE-CREATION = > api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallR= uleCmd.java 0dcba5f = > api/src/org/apache/cloudstack/api/command/user/firewall/CreatePortForwa= rdingRuleCmd.java 7d8dbb0 = > api/src/org/apache/cloudstack/api/command/user/firewall/DeleteEgressFir= ewallRuleCmd.java PRE-CREATION = > api/src/org/apache/cloudstack/api/command/user/firewall/ListEgressFirew= allRulesCmd.java PRE-CREATION = > api/src/org/apache/cloudstack/api/command/user/firewall/ListFirewallRul= esCmd.java 80581fb = > api/src/org/apache/cloudstack/api/command/user/loadbalancer/CreateLoadB= alancerRuleCmd.java b42ff4c = > api/src/org/apache/cloudstack/api/command/user/nat/CreateIpForwardingRu= leCmd.java c3894c4 = > api/src/org/apache/cloudstack/api/response/FirewallResponse.java 279925= 6 = > client/tomcatconf/commands.properties.in 182cbd8 = > core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource= .java 2dc7950 = > patches/systemvm/debian/config/etc/iptables/iptables-router 28469fb = > patches/systemvm/debian/config/opt/cloud/bin/ipassoc.sh 5af5d92 = > patches/systemvm/debian/config/root/firewallRule_egress.sh PRE-CREATION = > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/Vmw= areResource.java a444cfe = > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixRes= ourceBase.java 065d3be = > plugins/network-elements/juniper-srx/src/com/cloud/network/element/Juni= perSRXExternalFirewallElement.java ead2af9 = > scripts/network/domr/call_firewall.sh 08da341 = > server/src/com/cloud/api/ApiResponseHelper.java c346a6b = > server/src/com/cloud/network/NetworkManagerImpl.java 0a1fcd7 = > server/src/com/cloud/network/dao/FirewallRulesDao.java cc184c8 = > server/src/com/cloud/network/dao/FirewallRulesDaoImpl.java 2fff15a = > server/src/com/cloud/network/element/VirtualRouterElement.java 02a239e = > server/src/com/cloud/network/firewall/FirewallManagerImpl.java 340e872 = > server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java 9b48= f2c = > server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.= java 717da05 = > server/src/com/cloud/network/rules/FirewallManager.java 8473c56 = > server/src/com/cloud/network/rules/FirewallRuleVO.java 63ace5b = > server/src/com/cloud/network/rules/RulesManagerImpl.java a75aca3 = > server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java 67d6b8= c = > server/src/com/cloud/upgrade/dao/Upgrade40to41.java cd9e20c = > utils/conf/db.properties 18bf54c = > = > Diff: https://reviews.apache.org/r/9010/diff/ > = > = > Testing > ------- > = > Unit testing: > 1. Created egress rule for tcp port 22 from cloudstack UI. > 2. After adding the rule it allows tcp port 22 traffic. > 3. Remaining traffic got blocked. > = > = > Thanks, > = > Jayapal Reddy > = > --===============8908013400185379598==--