Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 66D1ECB7B for ; Sun, 27 Jan 2013 12:49:39 +0000 (UTC) Received: (qmail 88491 invoked by uid 500); 27 Jan 2013 12:49:39 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 87918 invoked by uid 500); 27 Jan 2013 12:49:34 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 87866 invoked by uid 99); 27 Jan 2013 12:49:32 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 27 Jan 2013 12:49:32 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3DBFB1C04A5; Sun, 27 Jan 2013 12:49:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3511081809574755275==" MIME-Version: 1.0 Subject: Re: Review Request: make maven use mkisofs or genisoimage depending on what is available From: "Rohit Yadav" To: "cloudstack" , "Noa Resare" , "Rohit Yadav" Date: Sun, 27 Jan 2013 12:49:25 -0000 Message-ID: <20130127124925.24984.17504@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Rohit Yadav" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/8838/ X-Sender: "Rohit Yadav" References: <20130104235141.29908.57181@reviews.apache.org> In-Reply-To: <20130104235141.29908.57181@reviews.apache.org> Reply-To: "Rohit Yadav" --===============3511081809574755275== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8838/#review15737 ----------------------------------------------------------- Ship it! Ship It! - Rohit Yadav On Jan. 4, 2013, 11:51 p.m., Noa Resare wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8838/ > ----------------------------------------------------------- > = > (Updated Jan. 4, 2013, 11:51 p.m.) > = > = > Review request for cloudstack. > = > = > Description > ------- > = > Due to differing licensing philosophies between the Debian project and th= e mkisofs maintainer the tool will probably never be shipped as part of Deb= ian. = > = > There is a tool named genisoimage that is command line parameter compatib= le with mkisofs and does the same thing. = > = > The attached patch uses the maven profile system to parameterize the bina= ry used to generate iso files depending on what is available on the system. > = > = > This addresses bug CLOUDSTACK-792. > = > = > Diffs > ----- > = > console-proxy/pom.xml 2526503 = > = > Diff: https://reviews.apache.org/r/8838/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Noa Resare > = > --===============3511081809574755275==--