Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============8164306599893394243=="
MIME-Version: 1.0
Subject: Re: Review Request: CLOUDSTACK-672: Set VMware cluster max. limit
 based on
 HV version
From: "Koushik Das" <koushik.das@citrix.com>
To: "cloudstack" <cloudstack-dev@incubator.apache.org>,
 "Koushik Das" <koushik.das@citrix.com>, "David Nalley" <david@gnsa.us>
Date: Sat, 26 Jan 2013 04:12:07 -0000
Message-ID: <20130126041207.5634.75176@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Koushik Das" <noreply@reviews.apache.org>
References: <20130121201517.9568.99902@reviews.apache.org>
In-Reply-To: <20130121201517.9568.99902@reviews.apache.org>
Reply-To: "Koushik Das" <koushik.das@citrix.com>

--===============8164306599893394243==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


> On Jan. 21, 2013, 8:15 p.m., David Nalley wrote:
> > setup/db/create-schema.sql, line 1613
> > <https://reviews.apache.org/r/9041/diff/1/?file=3D250528#file250528line=
1613>
> >
> >     You are setting the max_hosts_per_cluster for all VMware versions t=
o 32, yet I thought the proposal was only to affect 5.1 with the updated VM=
FS version.

Refer to my mail on http://mail-archives.apache.org/mod_mbox/incubator-clou=
dstack-dev/201301.mbox/%3C2529883E7B666F4E8F21F85AADA43CA7010C8F17211F@BANP=
MAILBOX01.citrite.net%3E

Also recently I saw another discussion on full clone support so this limita=
tion of 8 in earlir versions shouldn't hold.


> On Jan. 21, 2013, 8:15 p.m., David Nalley wrote:
> > setup/db/db/schema-40to410.sql, line 81
> > <https://reviews.apache.org/r/9041/diff/1/?file=3D250529#file250529line=
81>
> >
> >     You've altered the table and have now defined it as 32 in all versi=
ons here as well.

Same as above


- Koushik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9041/#review15550
-----------------------------------------------------------


On Jan. 21, 2013, 11:44 a.m., Koushik Das wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9041/
> -----------------------------------------------------------
> =

> (Updated Jan. 21, 2013, 11:44 a.m.)
> =

> =

> Review request for cloudstack.
> =

> =

> Description
> -------
> =

> For Vmware max. hosts in a cluster is specific to HV version. This config=
uration is read from the hypervisor_capabilities table.
> Read the dev list discussion here: http://apache.markmail.org/thread/lva7=
loblbksiavm7
> =

> Scenarios:
> - Adding a cluster to CS - From 1st host in the list of hosts discovered,=
 query the HV version. Based on the version read the max_hosts_per_cluster =
limit from hypervisor_capabilities table and do the validation
> - Adding a host to an existing cluster - Get the HV version from one of t=
he hosts already present in cluster from CS db., then similar to previous s=
cenario
> =

> The implementation is specific to Vmware only, haven't made the validatio=
n logic generic as there are no limits for other HVs currently.
> For upgraded scenarios, HV versions may not be present for the existing h=
ost table entries. In that case the 'default' version will get used to read=
 the limit.
> =

> =

> This addresses bug CLOUDSTACK-672.
> =

> =

> Diffs
> -----
> =

>   api/src/com/cloud/hypervisor/HypervisorCapabilities.java efb8a6a =

>   core/src/com/cloud/hypervisor/HypervisorCapabilitiesVO.java 56e8e0a =

>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServer=
Discoverer.java 684df54 =

>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/Vmwa=
reManager.java be3fe9f =

>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/Vmwa=
reManagerImpl.java c450312 =

>   server/src/com/cloud/configuration/Config.java 4ae144e =

>   server/src/com/cloud/hypervisor/dao/HypervisorCapabilitiesDao.java 8f4a=
475 =

>   server/src/com/cloud/hypervisor/dao/HypervisorCapabilitiesDaoImpl.java =
1a6fb72 =

>   setup/db/create-schema.sql 174f53c =

>   setup/db/db/schema-40to410.sql a9d168d =

> =

> Diff: https://reviews.apache.org/r/9041/diff/
> =

> =

> Testing
> -------
> =

> Manually verifed the scenarios mentioned above.
> =

> =

> Thanks,
> =

> Koushik Das
> =

>


--===============8164306599893394243==--