Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of srivatsav.prasanna@gmail.com
 designates 209.85.216.46 as permitted sender)
Sender: prasanna <srivatsav.prasanna@gmail.com>
Date: Thu, 10 Jan 2013 15:57:49 +0530
From: Prasanna Santhanam <tsp@apache.org>
To: "cloudstack-dev@incubator.apache.org"
 <cloudstack-dev@incubator.apache.org>
Subject: Re: [MERGE] Merge request: api_refactoring on master
Message-ID: <20130110102749.GB13309@cloud-2.local>
Mail-Followup-To: "cloudstack-dev@incubator.apache.org"
 <cloudstack-dev@incubator.apache.org>
References: <920FB93F-BECA-495C-8B07-CB8A46160E60@citrix.com>
 <CD13326A.4BCA%min.chen@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CD13326A.4BCA%min.chen@citrix.com>
User-Agent: Mutt/1.5.21 (2010-09-15)

On Wed, Jan 09, 2013 at 05:45:03PM -0500, Min Chen wrote:
> Hi Marcus,
> 
> To answer your question below:
> "Does this mean we won't see 10 "SELECT uuid FROM `vm_instance`
> WHERE id=3079 OR uuid='3079'" type calls for every VM we have when
> doing listVirtualMachines and such?"
> Yes, that is exactly one item we have fixed in api_refactoring in
> removing all IdentityProxy fields from all Response class, which
> will not invoke such select during JSON serialization phase for each
> VM.
> 

Min, speaking about the IdentityProxy it appears that all the
BaseAsyncCreateCmds right now refer back to the IdentityProxy via the
getEntityTable() method. This table is referred back in the
ApiResponseSerializer to execute the 'select id or uuid' stmt when
building response type in XML. JSON doesn't refer to this however. Can
we remove the IdentityProxy in these cases too?

Also the method getEntityTable() also should probably go away to
remove any traces of direct references back to the underlying db
entity?

-- 
Prasanna.,